Restructure graph/ subpackage to use __all__ and star imports#1944
Open
mdboom wants to merge 2 commits intoNVIDIA:mainfrom
Open
Restructure graph/ subpackage to use __all__ and star imports#1944mdboom wants to merge 2 commits intoNVIDIA:mainfrom
mdboom wants to merge 2 commits intoNVIDIA:mainfrom
Conversation
Add __all__ to each graph submodule and rewrite graph/__init__.py to use 'from ._module import *' pattern, matching the convention already used by _memory/ and system/ subpackages. - _graph_builder.pyx: __all__ = Graph, GraphBuilder, GraphCompleteOptions, GraphDebugPrintOptions - _graph_def.pyx: __all__ = Condition, GraphAllocOptions, GraphDef - _graph_node.pyx: __all__ = GraphNode - _subclasses.pyx: __all__ = all 15 node subclasses - __init__.py: replaced explicit named imports with star imports
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Migrate the
graph/subpackage to follow the same pattern used by_memory/andsystem/:__all__list__init__.pyusesfrom ._module import *to assemble the package namespaceChanges:
_graph_builder.pyx: added__all__ = ['Graph', 'GraphBuilder', 'GraphCompleteOptions', 'GraphDebugPrintOptions']_graph_def.pyx: added__all__ = ['Condition', 'GraphAllocOptions', 'GraphDef']_graph_node.pyx: added__all__ = ['GraphNode']_subclasses.pyx: added__all__with all 15 node subclassesgraph/__init__.py: replaced explicit named imports with star importsThis pattern allows modular organization with clear star-import behavior, making it easier to add or move components without updating the
__init__.pyeach time.EDIT: This was credited in the epic but got lost here -- this is based on @Andy-Jost's guideline that never got merged