Skip to content

Fix torch-incompatible assertions in TestViewCudaArrayInterfaceGPU #1999

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
leofang merged 6 commits into from
May 1, 2026
Merged

Fix torch-incompatible assertions in TestViewCudaArrayInterfaceGPU #1999

Changes from 4 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
24fc3aa
Fix torch-incompatible assertions in TestViewCudaArrayInterfaceGPU
leofang Apr 30, 2026
3969657
Fix strides assertion for torch CAI: allow explicit C-contiguous strides
leofang May 1, 2026
0af0ddc
Unify strides assertion pattern across all _check_view methods
leofang May 1, 2026
dacfec9
Merge branch 'main' into fix-test-utils-arr-size
leofang May 1, 2026
95a41aa
Merge remote-tracking branch 'origin/main' into fix-test-utils-arr-size
leofang May 1, 2026
6b017b7
Address review: flip strides assertion, add _arr_dtype, merge main
leofang May 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 11 additions & 8 deletions cuda_core/tests/test_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -171,7 +171,10 @@ def _check_view(self, view, in_arr):
assert view.shape == expected_shape
assert view.size == _arr_size(in_arr)
strides_in_counts = _arr_strides_in_counts(in_arr)
assert (_arr_is_c_contiguous(in_arr) and view.strides is None) or view.strides == strides_in_counts
if _arr_is_c_contiguous(in_arr):
assert view.strides in (None, strides_in_counts)
else:
assert view.strides == strides_in_counts
Comment thread
leofang marked this conversation as resolved.
Outdated
assert view.device_id == -1
assert view.is_device_accessible is False
assert view.exporting_obj is in_arr
Expand Down Expand Up @@ -343,15 +346,15 @@ def test_cuda_array_interface_gpu(self, in_arr, use_stream):

def _check_view(self, view, in_arr, dev):
assert isinstance(view, StridedMemoryView)
assert view.ptr == gpu_array_ptr(in_arr)
assert view.shape == in_arr.shape
assert view.size == in_arr.size
strides_in_counts = convert_strides_to_counts(in_arr.strides, in_arr.dtype.itemsize)
if in_arr.flags["C_CONTIGUOUS"]:
Comment thread
leofang marked this conversation as resolved.
assert view.strides is None
assert view.ptr == _arr_ptr(in_arr)
expected_shape = tuple(in_arr.shape)
assert view.shape == expected_shape
assert view.size == _arr_size(in_arr)
strides_in_counts = _arr_strides_in_counts(in_arr)
if _arr_is_c_contiguous(in_arr):
assert view.strides in (None, strides_in_counts)
else:
assert view.strides == strides_in_counts
Comment thread
leofang marked this conversation as resolved.
Outdated
assert view.dtype == in_arr.dtype
Comment thread
leofang marked this conversation as resolved.
assert view.device_id == dev.device_id
assert view.is_device_accessible is True
assert view.exporting_obj is in_arr
Expand Down
Loading