perf(pathfinder): fast-path exact directory searches#2425
Open
KRRT7 wants to merge 2 commits into
Open
Conversation
Signed-off-by: Kevin Turcios <turcioskevinr@gmail.com>
Signed-off-by: Kevin Turcios <turcioskevinr@gmail.com>
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Optimize exact directory discovery in
cuda.pathfinderby joining the complete candidate path and checking it once.Previously, exact paths were traversed one component at a time, resulting in one filesystem check per component. Wildcard paths retain the existing traversal behavior.
This affects the shared discovery path used for CUDA headers, binaries, static libraries, bitcode libraries, and dynamic-library locations.
A new cross-platform
pyperfbenchmark suite underbenchmarks/cuda_pathfinder/covers:Performance
Rigorous A/B measurements compared pristine
mainagainst this branch using identical environments and fixtures:Geometric mean: 1.68x faster.
The benchmark fixtures use NVIDIA wheel layouts such as:
nvidia/cuda_runtime/includenvidia/cuda_nvcc/binnvidia/cuda_runtime/libNotes