Merged
Conversation
Contributor
Member
Author
|
/ok to test |
Member
Author
|
/ok to test |
Member
Author
|
/ok to test |
leofang
added
the
to-be-backported
This comment has been minimized.
This comment has been minimized.
Member
Author
|
I haven't populated the PR description because it's the easiest if we review this together offline via a live demo. |
Contributor
|
per what you showed in the latest meeting I like the change. What is remaining for this to be non-draft? |
keenan-simpson
approved these changes
Jan 24, 2025
Member
Author
|
This release workflow would not be triggered automatically, and there is no code change in this PR, so let's admin-merge and test it live in the meeting. |
|
Backport failed because this pull request contains merge commits. You can either backport this pull request manually, or configure the action to skip merge commits. |
|
Member
Author
|
Note: Backport PR is #420. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Close #336. Close #71.