EXPERIMENT: typing edits as produced by Cursor, NO MANUAL CHANGES - #527
Closed
rwgk wants to merge 1 commit into
Closed
EXPERIMENT: typing edits as produced by Cursor, NO MANUAL CHANGES#527rwgk wants to merge 1 commit into
rwgk wants to merge 1 commit into
Conversation
This was the Cursor prompt:
I want to add typing annotations to the cuda_core code, to be checked with mypy when running the pre-commit command.
Note: I had to click the "Resume conversation" button several times (5+ probably).
Contributor
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
Contributor
Author
|
@shwina for visibility First impression: It still needs a lot of manual work, although it's probably better than nothing. |
Closed
Member
|
Can we not add/remove existing APIs (including their docs), and just focus on typing improvement? |
Contributor
Author
Absolutely. This was just meant to help us estimate how much manual effort it'll be. |
leofang
self-requested a review
May 2, 2025 14:27
leofang
added
enhancement
Contributor
Author
|
Closing this super-stale PR (random cleanup). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was the Cursor prompt:
Note: I had to click the "Resume conversation" button several times (5+ probably).
Cursor-0.47.8