Fix typos and grammar in documentation#774
Conversation
There was a problem hiding this comment.
Thank you for your contribution! Unfortunately, as per our contribution guide we cannot accept external contributions to the cuda_bindings folder due to the license restrictions. I'd like to ask you to kindly undo the changes there, and then we can merge. We'll treat those as a bug report and follow up in a separate PR.
btw, the change "pythonic -> Pythonic" is a matter of style choice. As long as we keep it consistent across the entire repo, the change is acceptable.
leofang
added
documentation
cluster2600
force-pushed
the
main
branch
2 times, most recently
from
ab172ee to
b26fc61
Compare
leofang
left a comment
leofang
left a comment
There was a problem hiding this comment.
Thanks, @cluster2600! To clarify, only the files under the two folders cuda_bindings/ and cuda_python/ have a non-permissive license; cuda_core/ and other files in this repo do accept external contributions.
There was a problem hiding this comment.
Please kindly undo bumping the lower bounds. We do not plan to chase after the latest 3rd party dependencies.
There was a problem hiding this comment.
Need to undo the changes to this file too.
Documentation fixes: - Fix capitalization (pythonic → Pythonic) for consistency across repo - Fix grammar (re-structured → restructured, bring up → introduce) - Fix subject-verb agreement (list interfaces are → is) - Fix SECURITY.md header reference (nvmath-python → CUDA Python) - Fix spelling errors (transferring, absence) - Fix verb forms (Set up, with vs against) - Fix directory paths (test/cython → tests/cython) Note: No dependency version bumps per maintainer request 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
|
Thank you for the clarification @leofang! I've updated the PR to address your feedback: ✅ Removed all dependency version bumps - I understand you don't want to chase the latest 3rd party dependencies The commit now contains only:
Thanks for explaining the contribution policy - this should now align with your maintenance preferences! |
|
3 participants
Description
This PR fixes multiple documentation and comment issues across the codebase to improve consistency, clarity, and correctness:
transfering→transferring,absense→absence)pythonic→Pythonic)re-structured→restructured,bring up→introduce)list interfaces are→is)meta package→metapackage)Setup→Set up)test/cython→tests/cython)against→with installations)These changes are non-functional and only affect text comments, documentation, and user-facing strings.
closes
Checklist