Add CI infrastructure overview with hand-drawn SVG diagram, Mermaid alternative, and enhanced artifact flow visualization to CONTRIBUTING.md - #916
Conversation
- Added cuda-pathfinder component to the component guidelines list - Added footnote explaining cuda.bindings follows cuda-python contributing guide - Added comprehensive CI infrastructure overview section with: - Visual flowchart diagram showing build → test → release pipeline - Platform and runner details (self-hosted vs GitHub-hosted) - Artifact storage and propagation (GitHub Artifacts vs Cache) - Branch-specific workflows (main, backport, pull-request) - Key infrastructure details Co-authored-by: leofang <5534781+leofang@users.noreply.github.com>
leofang
left a comment
There was a problem hiding this comment.
@copilot
The flow looks ok. But I'd like to highlight
- cuda-pathfinder artifact flows from the main branch's artifact space to that of the backport branch
- older cuda-bindings artifacts flow in the opposite direction
Please find a way to present it in the flowchart.
Also, if possible please generate a vectorized .svg file, and let's see how it looks. We will decide later if we want to revert back to the ascii-based one, like what you've generated.
…add SVG diagram Co-authored-by: leofang <5534781+leofang@users.noreply.github.com>
I've updated the flowchart to highlight the artifact flows between branches and created an SVG version as requested. The branch-specific artifact flow section now explicitly shows:
I've also created a vectorized SVG diagram (ci-pipeline.svg) with color-coded stages for better visualization. The documentation now includes both the SVG version and the ASCII version for different viewing preferences. Commit: 2816809 |
Co-authored-by: leofang <5534781+leofang@users.noreply.github.com>
…ayout Co-authored-by: leofang <5534781+leofang@users.noreply.github.com>
Co-authored-by: leofang <5534781+leofang@users.noreply.github.com>
Removed "Push to pull-request/* branches" trigger event from all CI documentation files as requested. Updated CONTRIBUTING.md Mermaid diagram, ci/ci-pipeline.svg, and ci/.ci-pipeline-regen.md regeneration instructions to exclude implementation-specific triggers. Commit: 9ce239a |
Co-authored-by: leofang <5534781+leofang@users.noreply.github.com>
Co-authored-by: leofang <5534781+leofang@users.noreply.github.com>
rwgk
left a comment
There was a problem hiding this comment.
There are still some minor glitches (a couple superfluous arrows), but I think this isn't worth our time, it's already great for merging.
|
Thanks, Ralf & Rob!
Yeah I am really unhappy with the arrow heads, but the SVG code looks fine to me and I don't have time to dig further. FWIW, I meant to ask if you have any preference over SVG or Mermaid. I don't, so let me keep both for now and wait until someone has an opinion 🙂 |
|
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.