CI: Avoid manual lookup of the run ID in the release workflow - #918
Conversation
Co-authored-by: leofang <5534781+leofang@users.noreply.github.com>
…dation Co-authored-by: leofang <5534781+leofang@users.noreply.github.com>
Co-authored-by: leofang <5534781+leofang@users.noreply.github.com>
leofang
left a comment
There was a problem hiding this comment.
One last sweep and we're done! I confirmed that the lookup-run-id script works locally.
|
@copilot |
…cript Co-authored-by: leofang <5534781+leofang@users.noreply.github.com>
|
pre-commit.ci autofix |
|
This is ready for review. No need to run it through the CI, because the release workflow would not be exercised until the release time. |
rwgk
left a comment
There was a problem hiding this comment.
This is awesome.
I usually weed out the 2>/dev/null code that ChatGPT seems to insert compulsively. It'd be ideal if you did that here, too. (Then admin merging would seem best.)
cryos
left a comment
There was a problem hiding this comment.
I would summarize the output to standard error as a way of offering debug and errors without polluting what is captured by the caller (the run ID). Seems reasonable and I see the logic. It works too and is something I wrote locally just the other day for another task and was about to look at here - you and copilot beat me again :-)
|
@rwgk confirmed with cuda-pathinder v1.2.2 release that the auto lookup works: |
This PR fixes an issue in the release workflow where the optional
run-idinput parameter was missing a default value, which could cause issues when the parameter is not provided.The changes include:
default: ""to the optionalrun-idinput parameterrun-idis not providedfetch-depth: 0requirement for git tag accessThe workflow now gracefully handles both scenarios:
run-idis provided manually (existing behavior preserved)run-idis omitted, it automatically detects the correct run ID from the provided git tagThis eliminates the need for manual lookup of run IDs while maintaining full backward compatibility.
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.