Conversation
Collaborator
Author
Command Bot: Processing... |
Comprehensive migration of the CUDA-Q C++ codebase from LLVM/MLIR 16 to LLVM/MLIR 22. Includes the LLVM submodule bump so this commit builds. Key changes: - Op creation: builder.create<Op>() -> Op::create(builder, ...) - Opaque pointer migration: typed LLVM pointers -> !llvm.ptr - Pass infrastructure: GEN_PASS_CLASSES -> per-pass GEN_PASS_DEF_* - API renames: StringRef methods, dyn_cast_or_null, modifyOpInPlace - CallByRefOp LLVM 22 interface requirements - CUDAQ_ENABLE_REST=OFF build fixes - All C++ test suites updated See LLVM_MIGRATION_CHANGELOG.md for detailed documentation. Co-authored-by: Alex McCaskey <amccaskey@nvidia.com> Co-authored-by: boschmitt <7152025+boschmitt@users.noreply.github.com> Signed-off-by: Alex McCaskey <amccaskey@nvidia.com> Signed-off-by: boschmitt <7152025+boschmitt@users.noreply.github.com>
Migrate all CUDA-Q Python bindings to nanobind (required by MLIR 22) and resolve cross-DSO LLVM Registry visibility issues. Key changes: - pybind11 -> nanobind across all py_*.cpp binding sources - Cross-DSO registry bridge functions for QPU, ServerHelper, Executor - nanobind-specific fixes: rv_policy, arg().none(), stl type casters - Python-side MLIR 22 adjustments: PassManager.run(module.operation) - Updated LLVM_MIGRATION_CHANGELOG.md sections 12.9-12.13 Co-authored-by: Alex McCaskey <amccaskey@nvidia.com> Co-authored-by: boschmitt <7152025+boschmitt@users.noreply.github.com> Signed-off-by: Alex McCaskey <amccaskey@nvidia.com> Signed-off-by: boschmitt <7152025+boschmitt@users.noreply.github.com>
This breaks the compiler's dependency to the runtime library. Signed-off-by: boschmitt <7152025+boschmitt@users.noreply.github.com>
Used nanobind 2.9.2 per mlir/python/requirements.txt.
Needed some explicit `py::arg("kwarg")` though most changes are from
clang-format.
Signed-off-by: Renaud Kauffmann <rkauffmann@nvidia.com>
Fixing build errors from llvm22 migration and formatting. --------- Signed-off-by: Sachin Pisal <spisal@nvidia.com>
Signed-off-by: Eric Schweitz <eschweitz@nvidia.com>
Signed-off-by: Eric Schweitz <eschweitz@nvidia.com>
…VM 22.1) Signed-off-by: Sachin Pisal <spisal@nvidia.com>
Signed-off-by: Eric Schweitz <eschweitz@nvidia.com>
Signed-off-by: Eric Schweitz <eschweitz@nvidia.com>
Signed-off-by: Eric Schweitz <eschweitz@nvidia.com>
behavior. Setting it to false through a reference changes that behavior and has potential side-effects beyond the current node being traversed. Back out these changes pending further investigation. Signed-off-by: Eric Schweitz <eschweitz@nvidia.com>
Signed-off-by: Eric Schweitz <eschweitz@nvidia.com>
Signed-off-by: Sachin Pisal <spisal@nvidia.com>
Signed-off-by: Sachin Pisal <spisal@nvidia.com>
Collaborator
Command Bot: Processing... |
Signed-off-by: Adam Geller <adgeller@nvidia.com>
Signed-off-by: Eric Schweitz <eschweitz@nvidia.com>
Signed-off-by: Eric Schweitz <eschweitz@nvidia.com>
Signed-off-by: Eric Schweitz <eschweitz@nvidia.com>
Signed-off-by: Eric Schweitz <eschweitz@nvidia.com>
Signed-off-by: Eric Schweitz <eschweitz@nvidia.com>
Signed-off-by: Eric Schweitz <eschweitz@nvidia.com>
Signed-off-by: Eric Schweitz <eschweitz@nvidia.com>
Signed-off-by: Eric Schweitz <eschweitz@nvidia.com>
Signed-off-by: Eric Schweitz <eschweitz@nvidia.com>
Collaborator
Command Bot: Processing... |
Signed-off-by: Eric Schweitz <eschweitz@nvidia.com>
Signed-off-by: Sachin Pisal <spisal@nvidia.com>
…into llvm22_update
Signed-off-by: Sachin Pisal <spisal@nvidia.com>
Collaborator
Command Bot: Processing... |
Signed-off-by: Sachin Pisal <spisal@nvidia.com>
…into llvm22_update
Collaborator
Command Bot: Processing... |
Signed-off-by: Sachin Pisal <spisal@nvidia.com>
Signed-off-by: Sachin Pisal <spisal@nvidia.com>
Collaborator
Command Bot: Processing... |
Signed-off-by: Sachin Pisal <spisal@nvidia.com>
Collaborator
Command Bot: Processing... |
Signed-off-by: Sachin Pisal <spisal@nvidia.com>
Collaborator
Command Bot: Processing... |
Signed-off-by: Sachin Pisal <spisal@nvidia.com>
Collaborator
Command Bot: Processing... |
Signed-off-by: Sachin Pisal <spisal@nvidia.com>
Signed-off-by: Sachin Pisal <spisal@nvidia.com>
Collaborator
Command Bot: Processing... |
Signed-off-by: Sachin Pisal <spisal@nvidia.com>
Collaborator
Command Bot: Processing... |
Signed-off-by: Sachin Pisal <spisal@nvidia.com>
Collaborator
Command Bot: Processing... |
Signed-off-by: Sachin Pisal <spisal@nvidia.com>
Collaborator
Command Bot: Processing... |
LLVM ERROR: can't create Attribute 'mlir::StringAttr' because storage uniquer isn't initialized: the dialect was likely not loaded. - Root cause - `libcudaq-mlir-runtime.so` had its own TypeID copies on Linux.The Apple-only CAPI-prepend block was never extended to Linux. - Appended `$ORIGIN/../cudaq/mlir/_mlir_libs` (wheel/install layout) and `$ORIGIN/../python/cudaq/mlir/_mlir_libs` (build tree) to the global Linux `CMAKE_INSTALL_RPATH` - Wheel build used BFD ld, not LLD, on Linux. `build_cudaq.sh` passes `-DLLVM_USE_LINKER=lld` but scikit-build-core didn't. Under BFD, the CAPI-prepend trick fails for `_quakeDialects.so`. Added a Linux-only override in `pyproject.toml`, `pyproject.toml.cu12`, `pyproject.toml.cu13`. --------- Signed-off-by: Sachin Pisal <spisal@nvidia.com>
Collaborator
Command Bot: Processing... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Just pushing this draft to have the new devdeps container generated