NoiseLearning add cutn support#566
Draft
vedika-saravanan wants to merge 3 commits into
Draft
Conversation
Signed-off-by: vedika-saravanan <vsaravanan@nvidia.com>
15fb964 to
80de5f4
Compare
Signed-off-by: vedika-saravanan <vsaravanan@nvidia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds cuTensorNet support to NMOptimizer (differentiable noise learning). New precontract_noise=True mode runs the main contraction on the reduced-TN topology with noise contracted into checks per step, plus a hybrid path-finder that picks between cotengra and the user's optimizer subject to an executability check.
Runtime / performance impact
details shared in internal slack channel. Slack me for the data.
Self-review checklist
Please confirm each item before requesting review. Check
[x]or strikethrough and explain.
Before requesting review
Scope and size
(if so, an issue has been raised).
Tests
just when it is missing.
EXPECT_*/assertchecks areinsufficient for algorithmic correctness.
Documentation
tracked.
release (the docs site publishes immediately on merge to the default
branch, so feature docs must not land before the feature ships).
Code style
snake_casevscamelCase) forthe area being modified.
Dependencies
OSRB tickets filed.