Skip to content

NoiseLearning add cutn support#566

Draft
vedika-saravanan wants to merge 3 commits into
NVIDIA:mainfrom
vedika-saravanan:noise_learn_cutn_support
Draft

NoiseLearning add cutn support#566
vedika-saravanan wants to merge 3 commits into
NVIDIA:mainfrom
vedika-saravanan:noise_learn_cutn_support

Conversation

@vedika-saravanan
Copy link
Copy Markdown
Collaborator

@vedika-saravanan vedika-saravanan commented May 26, 2026

Description

Adds cuTensorNet support to NMOptimizer (differentiable noise learning). New precontract_noise=True mode runs the main contraction on the reduced-TN topology with noise contracted into checks per step, plus a hybrid path-finder that picks between cotengra and the user's optimizer subject to an executability check.

Runtime / performance impact

details shared in internal slack channel. Slack me for the data.

Self-review checklist

Please confirm each item before requesting review. Check [x] or strike
through and explain.

Before requesting review

  • I reviewed my own full diff in GitHub or my editor.
  • PR is in Draft if it is not yet ready for review.
  • Temporary / debugging changes have been removed.
  • Local test logs reviewed; no unexplained warnings or errors.
  • CI logs reviewed; no unexplained warnings or errors.
  • Full CI has been run.

Scope and size

  • PR is under ~1000 lines, or an exception is justified in the description.
  • Refactoring-only changes are isolated in their own PR(s).
  • No existing tests were disabled or modified just to make this PR pass
    (if so, an issue has been raised).

Tests

  • New functionality has new tests.
  • Tests fail if the new functionality is broken (including crashes), not
    just when it is missing.
  • Negative tests added where exceptions are expected.
  • Truth data added where simple EXPECT_* / assert checks are
    insufficient for algorithmic correctness.
  • CI runtime impact considered; team notified if significant.

Documentation

  • Public-facing APIs have Doxygen docs.
  • User-visible behavior changes have public docs, or a follow-up is
    tracked.
  • User-facing docs for new features are in a separate PR held until
    release (the docs site publishes immediately on merge to the default
    branch, so feature docs must not land before the feature ships).

Code style

  • Naming follows the existing convention (snake_case vs camelCase) for
    the area being modified.

Dependencies

  • No new third-party dependencies, or the team has been notified and
    OSRB tickets filed.

Signed-off-by: vedika-saravanan <vsaravanan@nvidia.com>
@vedika-saravanan vedika-saravanan force-pushed the noise_learn_cutn_support branch from 15fb964 to 80de5f4 Compare May 29, 2026 03:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant