Bugfix in PR workflow job filtering#593
Open
anjbur wants to merge 4 commits into
Open
Conversation
Signed-off-by: Angela Burton <angelab@nvidia.com>
Signed-off-by: Angela Burton <angelab@nvidia.com>
This reverts commit 00c520e. Signed-off-by: Angela Burton <angelab@nvidia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Bugfix for PR workflow filtering. Currently, it compares the PR branch against
base.sha, which resolves as the most recent commit on the PR's base branch (i.e. main). If the PR branch hasn't pulled the most up-to-date version of main, then this diff will include any changes made on main since they last pulled an update. Changing this tobase.refinstead resolves to the base branch name (main) and the diff will be taken against the merge-base.In short, this will prevent unnecessary jobs running in the CI when a feature branch is pushed without the most recent changes on main.
See the triggered CI checks below on 00c520e for confirmation of the bug.
Runtime / performance impact
Self-review checklist
Please confirm each item before requesting review. Check
[x]or strikethrough and explain.
Before requesting review
Scope and size
(if so, an issue has been raised).
Tests
just when it is missing.
EXPECT_*/assertchecks areinsufficient for algorithmic correctness.
Documentation
tracked.
release (the docs site publishes immediately on merge to the default
branch, so feature docs must not land before the feature ships).
Code style
snake_casevscamelCase) forthe area being modified.
Dependencies
OSRB tickets filed.