-
Notifications
You must be signed in to change notification settings - Fork 162
Migrate RMM usage to CCCL MR design #1035
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
2970a07
536a692
31a6eab
f889d28
76c9ece
24d3036
8506b5d
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,28 @@ | ||
| #!/bin/bash | ||
| # SPDX-FileCopyrightText: Copyright (c) 2025-2026, NVIDIA CORPORATION. | ||
| # SPDX-License-Identifier: Apache-2.0 | ||
|
|
||
| # download CI artifacts | ||
| LIBRMM_CHANNEL=$(rapids-get-pr-artifact rmm 2361 cpp conda) | ||
| RMM_CHANNEL=$(rapids-get-pr-artifact rmm 2361 python conda --stable) | ||
| LIBUCXX_CHANNEL=$(rapids-get-pr-artifact ucxx 636 cpp conda) | ||
| UCXX_CHANNEL=$(rapids-get-pr-artifact ucxx 636 python conda --stable) | ||
| LIBRAFT_CHANNEL=$(rapids-get-pr-artifact raft 2996 cpp conda) | ||
| RAFT_CHANNEL=$(rapids-get-pr-artifact raft 2996 python conda --stable) | ||
|
bdice marked this conversation as resolved.
|
||
|
|
||
| RAPIDS_PREPENDED_CONDA_CHANNELS=( | ||
| "${LIBRMM_CHANNEL}" | ||
| "${RMM_CHANNEL}" | ||
| "${LIBUCXX_CHANNEL}" | ||
| "${UCXX_CHANNEL}" | ||
| "${LIBRAFT_CHANNEL}" | ||
| "${RAFT_CHANNEL}" | ||
| ) | ||
| export RAPIDS_PREPENDED_CONDA_CHANNELS | ||
|
|
||
| RAPIDS_EXTRA_CONDA_CHANNEL_ARGS=() | ||
| for _channel in "${RAPIDS_PREPENDED_CONDA_CHANNELS[@]}" | ||
| do | ||
| conda config --system --add channels "${_channel}" | ||
| RAPIDS_EXTRA_CONDA_CHANNEL_ARGS+=(--prepend-channel "${_channel}") | ||
| done | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,33 @@ | ||
| #!/bin/bash | ||
| # SPDX-FileCopyrightText: Copyright (c) 2025-2026, NVIDIA CORPORATION. | ||
| # SPDX-License-Identifier: Apache-2.0 | ||
|
|
||
| RAPIDS_PY_CUDA_SUFFIX=$(rapids-wheel-ctk-name-gen "${RAPIDS_CUDA_VERSION}") | ||
|
|
||
| LIBRMM_WHEELHOUSE=$( | ||
| RAPIDS_PY_WHEEL_NAME="librmm_${RAPIDS_PY_CUDA_SUFFIX}" rapids-get-pr-artifact rmm 2361 cpp wheel | ||
| ) | ||
| RMM_WHEELHOUSE=$( | ||
| rapids-get-pr-artifact rmm 2361 python wheel --stable | ||
| ) | ||
| LIBUCXX_WHEELHOUSE=$( | ||
| RAPIDS_PY_WHEEL_NAME="libucxx_${RAPIDS_PY_CUDA_SUFFIX}" rapids-get-pr-artifact ucxx 636 cpp wheel | ||
| ) | ||
| UCXX_WHEELHOUSE=$( | ||
| rapids-get-pr-artifact ucxx 636 python wheel --stable | ||
| ) | ||
| LIBRAFT_WHEELHOUSE=$( | ||
| RAPIDS_PY_WHEEL_NAME="libraft_${RAPIDS_PY_CUDA_SUFFIX}" rapids-get-pr-artifact raft 2996 cpp wheel | ||
| ) | ||
| RAFT_WHEELHOUSE=$( | ||
| rapids-get-pr-artifact raft 2996 python wheel --stable --pkg_name pylibraft | ||
| ) | ||
|
bdice marked this conversation as resolved.
|
||
|
|
||
| cat >> "${PIP_CONSTRAINT}" <<EOF | ||
| librmm-${RAPIDS_PY_CUDA_SUFFIX} @ file://$(echo "${LIBRMM_WHEELHOUSE}"/librmm_*.whl) | ||
| rmm-${RAPIDS_PY_CUDA_SUFFIX} @ file://$(echo "${RMM_WHEELHOUSE}"/rmm_*.whl) | ||
| libucxx-${RAPIDS_PY_CUDA_SUFFIX} @ file://$(echo "${LIBUCXX_WHEELHOUSE}"/libucxx_*.whl) | ||
| ucxx-${RAPIDS_PY_CUDA_SUFFIX} @ file://$(echo "${UCXX_WHEELHOUSE}"/ucxx_*.whl) | ||
| libraft-${RAPIDS_PY_CUDA_SUFFIX} @ file://$(echo "${LIBRAFT_WHEELHOUSE}"/libraft_*.whl) | ||
| pylibraft-${RAPIDS_PY_CUDA_SUFFIX} @ file://$(echo "${RAFT_WHEELHOUSE}"/pylibraft_*.whl) | ||
| EOF | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -247,8 +247,8 @@ class sparse_cholesky_cudss_t : public sparse_cholesky_base_t<i_t, f_t> { | |
| CUDSS_CALL_AND_CHECK_EXIT(cudssSetStream(handle, stream), status, "cudaStreamCreate"); | ||
|
|
||
| mem_handler.ctx = reinterpret_cast<void*>(handle_ptr_->get_workspace_resource()); | ||
| mem_handler.device_alloc = cudss_device_alloc<rmm::mr::device_memory_resource>; | ||
| mem_handler.device_free = cudss_device_dealloc<rmm::mr::device_memory_resource>; | ||
| mem_handler.device_alloc = cudss_device_alloc<void>; | ||
| mem_handler.device_free = cudss_device_dealloc<void>; | ||
|
Comment on lines
+250
to
+251
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. It doesn't seem like this template parameter is being used. The
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I confirm, it is not used |
||
|
|
||
| CUDSS_CALL_AND_CHECK_EXIT( | ||
| cudssSetDeviceMemHandler(handle, &mem_handler), status, "cudssSetDeviceMemHandler"); | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -15,6 +15,8 @@ | |
|
|
||
| #include <mip_heuristics/mip_constants.hpp> | ||
|
|
||
| #include <thrust/iterator/transform_output_iterator.h> | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Is it an intentional change? |
||
|
|
||
| #include <raft/sparse/detail/cusparse_wrappers.h> | ||
| #include <raft/core/nvtx.hpp> | ||
| #include <raft/linalg/detail/cublas_wrappers.hpp> | ||
|
|
||
Uh oh!
There was an error while loading. Please reload this page.