fix(security): remove insecure SSL verification bypass in dataset downloaders#1108
Merged
rgsl888prabhu merged 2 commits intoNVIDIA:mainfrom Apr 16, 2026
Merged
Conversation
…nloaders Remove ssl.CERT_NONE and check_hostname=False bypass for plato.asu.edu URLs. The site has a valid SSL certificate so the bypass is unnecessary. Fixes SonarQube vulnerabilities: - python:S4830 (server certificate verification disabled) - python:S5527 (server hostname verification disabled)
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughRemoves SSL certificate verification bypass logic that was conditionally applied to Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes 🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Iroy30
approved these changes
Apr 15, 2026
Collaborator
Author
|
/merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ssl.CERT_NONEandcheck_hostname = Falsebypass forplato.asu.eduURLs in dataset download scriptsimport sslFixes SonarQube rules
python:S4830andpython:S5527(the only 2 open security vulnerabilities in the report).Test plan
regression/get_datasets.pyand verify plato.asu.edu downloads succeed without SSL bypassbenchmarks/linear_programming/utils/get_datasets.pyand verify same