fix(ci): fix typo in notebook skip list for transport_cuopt#1496
Open
ramakrishnap-nv wants to merge 3 commits into
Open
fix(ci): fix typo in notebook skip list for transport_cuopt#1496ramakrishnap-nv wants to merge 3 commits into
ramakrishnap-nv wants to merge 3 commits into
Conversation
…MP tests The test crashes Julia's JIT compiler with SIGSEGV (signal 11) during type inference for the MOI bridge_optimizer delete path when a SecondOrderCone variable with a negative initial bound is removed. All other cuOpt.jl tests pass (286 pass, 22 skip across 7 nightly wheel jobs). Patch the cloned cuOpt.jl MOI_wrapper.jl to add this test to the exclude list in test_runtests_bridge_optimizer, following the same pattern used for test_air05. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
The test_conic_SecondOrderCone_negative_initial_bound exclusion is now handled directly in cuOpt.jl via jump-dev/cuOpt.jl#39, which is the correct place for test configuration rather than a sed patch in CI. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
ramakrishnap-nv
added
bug
tmckayus
approved these changes
Jun 30, 2026
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughThis PR makes two minor CI script edits: a blank line added after a conditional block in run_jump_tests.sh, and a typo correction in nbtest.sh changing the skip pattern string "trnsport_cuopt" to "transport_cuopt" in the SKIP_NOTEBOOKS array. ChangesCI Script Edits
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
ramakrishnap-nv
force-pushed
the
fix/nbtest-transport-skip-typo
branch
from
5908588 to
66cbfb6
Compare
CI Test Summary16 failed · 15 passed · 0 skipped |
'trnsport_cuopt' → 'transport_cuopt': the missing 'a' meant the pattern never matched, so GAMSPy_integration_example/transport_cuopt.ipynb was never skipped. It ran and failed with: gmscuopt: error while loading shared libraries: libcublas.so.13: cannot open shared object file The GAMS cuOpt integration requires LD_LIBRARY_PATH configuration that the conda notebook test environment does not provide, so the notebook is intentionally skipped until that setup is in place. Fixes: https://github.com/NVIDIA/cuopt/actions/runs/28426561531/job/84404065735 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
ramakrishnap-nv
force-pushed
the
fix/nbtest-transport-skip-typo
branch
from
66cbfb6 to
1b56c83
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Typo in skip list:
trnsport_cuopt→transport_cuopt(missing 'a'). The pattern never matched so the GAMSPy notebook ran instead of being skipped, failing with a missinglibcublas.so.13.