-
Notifications
You must be signed in to change notification settings - Fork 199
Deprecate LP batch solve across Python, server, and docs #915
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
3da16b1
Deprecate LP batch solve across Python, server, and docs
anandhkb e616549
Address PR #915 review: warmstart guard, docs, timing, tests
anandhkb da40023
Address PR #915 review: per-item solver settings, comment cleanup, do…
anandhkb 3372656
Style: update copyright year to 2026
anandhkb 0ff95be
Bump CUOPT_MAX_RESULT to 2 in self-hosted server tests
anandhkb 39de335
only issue deprecation warnings
Iroy30 45d751a
update docs
Iroy30 3bcb7a4
update test
Iroy30 6c6d5b8
Merge branch 'main' into deprecateBatchLP
Iroy30 8221675
Update test_self_hosted_service.sh
Iroy30 13d011d
Merge branch 'main' into deprecateBatchLP
Iroy30 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -343,7 +343,10 @@ def create_solution(sol): | |
| if type(LP_data) is list: | ||
| is_batch = True | ||
| data_model_list = [] | ||
| warnings = [] | ||
| warnings = [ | ||
| "LP batch mode is deprecated and will be removed in a future release. " | ||
| "Use sequential Solve() calls or implement your own parallelism." | ||
| ] | ||
| for i_data in LP_data: | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. We are calling batch LP but have changed it to sequential solves under the hood which is misleading
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Understood. So what is your recommendation? |
||
| i_warnings, data_model = create_data_model(i_data) | ||
| data_model_list.append(data_model) | ||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.