[CuTe][SM70] Add comment clarifying signed cast requirement for blockIdx coords#3203
Open
Flink-ddd wants to merge 1 commit intoNVIDIA:mainfrom
Open
[CuTe][SM70] Add comment clarifying signed cast requirement for blockIdx coords#3203Flink-ddd wants to merge 1 commit intoNVIDIA:mainfrom
Flink-ddd wants to merge 1 commit intoNVIDIA:mainfrom
Conversation
f3e2f05 to
e6aeff4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
blockIdx returns uint3, so m_coord, n_coord, and l_coord are unsigned. When these are passed directly to make_coord, the tile residue calculations:
can produce negative values for small problem shapes (e.g. M=8, N=8 with TileShape=128x128). With unsigned arithmetic, these wrap around to large positive values, causing incorrect predication and wrong results.
Fix
The int() cast in make_coord was already present in
sm70_gemm.hppandsm70_gemm_array.hpp, but without explanation. This PR adds a comment to clarify why the cast is necessary, so users writing custom kernels based on these files do not accidentally omit it.Reported in #3190.