Skip to content

tests: cover a completed parallel_attempts run #1816

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
EphraiemSarabamoun wants to merge 1 commit into
base: main
Choose a base branch
from
+14 −0
Open

tests: cover a completed parallel_attempts run #1816

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions tests/test_config.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -847,6 +847,20 @@ def test_site_yaml_overrides_max_workers(capsys):
assert exc_info.value.code == 1


# a run with parallel_attempts set should complete without error, for both the
# serial case (1) and a parallel case (>1). uses the cheap CPU-only test
# generator and the multi-prompt test.Test probe so that the >1 case actually
# reaches the multiprocessing path in garak.probes.base.Probe._execute_all
@pytest.mark.parametrize("parallel_attempts", [1, 4])
Comment thread
leondz marked this conversation as resolved.
def test_parallel_attempts_run_completes(parallel_attempts):
args = (
f"--parallel_attempts {parallel_attempts} -m test.Blank -p test.Test -g 1"
).split()
garak.cli.main(args)

assert _config.system.parallel_attempts == parallel_attempts
Copy link
Copy Markdown
Collaborator

@leondz leondz Jun 1, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

asserts should have a message describing the desired condition. e.g. "--parallel_atempts cli param should pass through to _config.system"



model_target_data = [
("model_type", "model_name"),
("model_type", "target_name"),
Expand Down
Loading