fix: keep Replicate private endpoint output as one Message#1836
Open
fallintoplace wants to merge 1 commit into
Open
fix: keep Replicate private endpoint output as one Message#1836fallintoplace wants to merge 1 commit into
fallintoplace wants to merge 1 commit into
Conversation
Signed-off-by: Minh Vu <vuhoangminh97@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
private Replicate endpoints already join
prediction.outputinto one string, but the private endpoint path then iterates that string when building the return value.so a response like
"hello"becomes a list of per-character messages instead of a singleMessage("hello").this PR:
Messagefor the joined responseprediction.outputverification
PYTHONPATH=/Users/hoangvu/Code/OSS/garak /tmp/garak-pr-venv/bin/python -m pytest tests/generators/test_replicate.py_call_model()returns one message per characterI didn't run a live private Replicate endpoint check here, and I didn't run the full
tests/suite in this local environment.