feat: log skip reason when detectors are skipped during scan#1845
Closed
Oxygen56 wants to merge 1 commit into
Closed
feat: log skip reason when detectors are skipped during scan#1845Oxygen56 wants to merge 1 commit into
Oxygen56 wants to merge 1 commit into
Conversation
Previously, when a detector had skip=True (e.g., AlwaysSkip detector), the harness silently continued with no indication to the user about why the detector was not run. Changes: - Add skip_reason attribute to Detector base class - Log the reason at INFO level when a detector is skipped - Default reason is 'disabled via config' when skip_reason is not set Fixes NVIDIA#1061 Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
jmartin-tech
requested changes
Jun 6, 2026
Collaborator
jmartin-tech
left a comment
jmartin-tech
left a comment
There was a problem hiding this comment.
This PR does not name sense, adding an attribute and never setting it does not provide a reason why the detector was skipped.
Using coding assistants to aid in contribution to this project is considered acceptable, this PR however includes changes that suggest the author has not reviewed the code before offering the revision.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Fixes #1061 — Detectors that skip probes now log their skip reason.
Problem
When
skip=True, the harness silently continued. Users had no idea which detectors were skipped or why.Fix
skip_reasonattributeExample