test(gdrcopy): precompiled

Signed-off-by: Justin Bera <justin.bera@datadoghq.com>

Author: just1not2

api/nvidia/v1alpha1/nvidiadriver_types_test.go

@@ -402,3 +402,127 @@ func TestGDRCopyGetImagePath(t *testing.T) {
 		})
 	}
 }
+
+func TestGDRCopyGetPrecompiledImagePath(t *testing.T) {
+	testCases := []struct {
+		description   string
+		spec          *GDRCopySpec
+		osVersion     string
+		kernelVersion string
+		errorExpected bool
+		expectedImage string
+	}{
+		{
+			description: "malformed repository",
+			spec: &GDRCopySpec{
+				Repository: "malformed?/repo",
+			},
+			errorExpected: true,
+			expectedImage: "",
+		},
+		{
+			description: "malformed image",
+			spec: &GDRCopySpec{
+				Image: "malformed?image",
+			},
+			errorExpected: true,
+			expectedImage: "",
+		},
+		{
+			description: "only image provided with no tag or digest",
+			spec: &GDRCopySpec{
+				Image: "nvcr.io/nvidia/cloud-native/gdrdrv",
+			},
+			errorExpected: true,
+			expectedImage: "",
+		},
+		{
+			description: "only image provided with tag",
+			spec: &GDRCopySpec{
+				Image: "nvcr.io/nvidia/cloud-native/gdrdrv:v2.5.2",
+			},
+			osVersion:     "ubuntu22.04",
+			kernelVersion: "5.4.0-150-generic",
+			expectedImage: "nvcr.io/nvidia/cloud-native/gdrdrv:v2.5.2-5.4.0-150-generic-ubuntu22.04",
+		},
+		{
+			description: "only image provided with digest",
+			spec: &GDRCopySpec{
+				Image: "nvcr.io/nvidia/cloud-native/gdrdrv@sha256:" + testDigest,
+			},
+			osVersion:     "ubuntu22.04",
+			kernelVersion: "5.4.0-150-generic",
+			errorExpected: true,
+			expectedImage: "",
+		},
+		{
+			description: "repository, image, and version set but image contains a tag",
+			spec: &GDRCopySpec{
+				Repository: "nvcr.io/nvidia/cloud-native",
+				Image:      "nvcr.io/nvidia/cloud-native/gdrdrv:v2.4.1",
+				Version:    "v2.5.2",
+			},
+			osVersion:     "ubuntu22.04",
+			kernelVersion: "5.4.0-150-generic",
+			errorExpected: true,
+			expectedImage: "",
+		},
+		{
+			description: "repository, image, and version set but image contains a digest",
+			spec: &GDRCopySpec{
+				Repository: "nvcr.io/nvidia/cloud-native",
+				Image:      "nvcr.io/nvidia/cloud-native/gdrdrv@sha256:" + testDigest,
+				Version:    "v2.5.2",
+			},
+			osVersion:     "ubuntu22.04",
+			kernelVersion: "5.4.0-150-generic",
+			errorExpected: true,
+			expectedImage: "",
+		},
+		{
+			description: "missing version",
+			spec: &GDRCopySpec{
+				Repository: "nvcr.io/nvidia/cloud-native",
+				Image:      "gdrdrv",
+			},
+			osVersion:     "ubuntu22.04",
+			kernelVersion: "5.4.0-150-generic",
+			errorExpected: true,
+			expectedImage: "",
+		},
+		{
+			description: "repository, image, and version set; version is a tag",
+			spec: &GDRCopySpec{
+				Repository: "nvcr.io/nvidia/cloud-native",
+				Image:      "gdrdrv",
+				Version:    "v2.5.2",
+			},
+			osVersion:     "ubuntu22.04",
+			kernelVersion: "5.4.0-150-generic",
+			expectedImage: "nvcr.io/nvidia/cloud-native/gdrdrv:v2.5.2-5.4.0-150-generic-ubuntu22.04",
+		},
+		{
+			description: "repository, image, and version set; version is a digest",
+			spec: &GDRCopySpec{
+				Repository: "nvcr.io/nvidia/cloud-native",
+				Image:      "gdrdrv",
+				Version:    "sha256:" + testDigest,
+			},
+			osVersion:     "ubuntu22.04",
+			kernelVersion: "5.4.0-150-generic",
+			errorExpected: true,
+		},
+	}
+
+	for _, tc := range testCases {
+		t.Run(tc.description, func(t *testing.T) {
+			image, err := tc.spec.GetPrecompiledImagePath(tc.osVersion, tc.kernelVersion)
+			if tc.errorExpected {
+				require.Error(t, err)
+			} else {
+				require.NoError(t, err)
+			}
+			require.Equal(t, image, tc.expectedImage)
+		})
+	}
+}

controllers/object_controls_test.go

@@ -2292,3 +2292,62 @@ func TestDriverPrecompiledLibModulesSuse(t *testing.T) {
 		})
 	}
 }
+
+// TestGDRCopyResolveDriverTag tests that resolveDriverTag returns the correct
+// image path for GDRCopy in both non-precompiled and precompiled modes.
+func TestGDRCopyResolveDriverTag(t *testing.T) {
+	const (
+		repo    = "nvcr.io/nvidia/cloud-native"
+		image   = "gdrdrv"
+		version = "v2.5.2"
+		kernel  = "5.4.0-150-generic"
+		osTag   = "ubuntu22.04"
+	)
+
+	n := ClusterPolicyController{
+		currentKernelVersion: kernel,
+		gpuNodeOSTag:         osTag,
+		singleton:            &gpuv1.ClusterPolicy{},
+	}
+
+	t.Run("non-precompiled", func(t *testing.T) {
+		spec := &gpuv1.GDRCopySpec{Repository: repo, Image: image, Version: version}
+		got, err := resolveDriverTag(n, spec)
+		require.NoError(t, err)
+		require.Equal(t, repo+"/"+image+":"+version+"-"+osTag, got)
+	})
+
+	t.Run("precompiled", func(t *testing.T) {
+		spec := &gpuv1.GDRCopySpec{Repository: repo, Image: image, Version: version, UsePrecompiled: ptr.To(true)}
+		got, err := resolveDriverTag(n, spec)
+		require.NoError(t, err)
+		require.Equal(t, repo+"/"+image+":"+version+"-"+kernel+"-"+osTag, got)
+	})
+}
+
+// TestGDRCopyPrecompiledDriverIncompatibility tests that enabling precompiled
+// drivers without enabling precompiled GDRCopy returns an error.
+func TestGDRCopyPrecompiledDriverIncompatibility(t *testing.T) {
+	cp := getDriverTestInput("precompiled")
+	enabled := true
+	cp.Spec.GDRCopy = &gpuv1.GDRCopySpec{
+		Enabled:        &enabled,
+		Repository:     "nvcr.io/nvidia/cloud-native",
+		Image:          "gdrdrv",
+		Version:        "v2.5.2",
+		UsePrecompiled: ptr.To(false),
+	}
+
+	err := updateClusterPolicy(&clusterPolicyController, cp)
+	require.NoError(t, err)
+
+	addState(&clusterPolicyController, filepath.Join(cfg.root, driverAssetsPath))
+	// step() returns an error without incrementing idx, so the state is still at idx
+	defer func() {
+		_ = removeState(&clusterPolicyController, clusterPolicyController.idx)
+	}()
+
+	_, err = clusterPolicyController.step()
+	require.Error(t, err, "expected error when driver is precompiled but GDRCopy is not")
+	require.Contains(t, err.Error(), "GDRCopy is not supported")
+}