Skip to content

Remove deprecated initContainer in helm template #2519

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dttung2905 wants to merge 1 commit into
base: main
Choose a base branch
from
+0 −27
Open

Remove deprecated initContainer in helm template #2519

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 0 additions & 18 deletions deployments/gpu-operator/templates/clusterpolicy.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,24 +25,6 @@ spec:
{{- if .Values.operator.defaultGPUMode }}
defaultGPUMode: {{ .Values.operator.defaultGPUMode }}
{{- end }}
{{- if .Values.operator.initContainer }}
initContainer:
{{- if .Values.operator.initContainer.repository }}
repository: {{ .Values.operator.initContainer.repository }}
{{- end }}
{{- if .Values.operator.initContainer.image }}
image: {{ .Values.operator.initContainer.image }}
{{- end }}
{{- if .Values.operator.initContainer.version }}
version: {{ .Values.operator.initContainer.version | quote }}
{{- end }}
{{- if .Values.operator.initContainer.imagePullPolicy }}
imagePullPolicy: {{ .Values.operator.initContainer.imagePullPolicy }}
{{- end }}
{{- if .Values.operator.initContainer.imagePullSecrets }}
imagePullSecrets: {{ toYaml .Values.operator.initContainer.imagePullSecrets | nindent 8 }}
{{- end }}
{{- end }}
{{- if .Values.operator.use_ocp_driver_toolkit }}
use_ocp_driver_toolkit: {{ .Values.operator.use_ocp_driver_toolkit }}
{{- end }}
Expand Down
7 changes: 0 additions & 7 deletions tests/scripts/env-to-values.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,6 @@ set -euo pipefail
# - TOOLKIT_CONTAINER_IMAGE: container-toolkit image override
# - DEVICE_PLUGIN_IMAGE: device-plugin image override
# - MIG_MANAGER_IMAGE: mig-manager image override
# - CONTAINER_RUNTIME: default runtime (docker, containerd, crio)

if [[ $# -ne 1 ]]; then
echo "Usage: $0 OUTPUT_FILE" >&2
Expand Down Expand Up @@ -70,12 +69,6 @@ if [[ -n "${OPERATOR_VERSION:-}" ]]; then
HAS_VALUES=true
fi

if [[ -n "${CONTAINER_RUNTIME:-}" ]]; then
OPERATOR_CONFIG="${OPERATOR_CONFIG} defaultRuntime: \"${CONTAINER_RUNTIME}\"\n"
echo "Added operator.defaultRuntime: ${CONTAINER_RUNTIME}"
HAS_VALUES=true
fi

# Write operator configuration if any
if [[ -n "${OPERATOR_CONFIG}" ]]; then
echo "operator:" >> "${OUTPUT_FILE}"
Expand Down
2 changes: 0 additions & 2 deletions tests/scripts/install-operator.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,8 +26,6 @@ if [[ "${USE_VALUES_FILE}" == "false" ]]; then
if [[ -n "${OPERATOR_VERSION}" ]]; then
OPERATOR_OPTIONS="${OPERATOR_OPTIONS} --set operator.version=${OPERATOR_VERSION} --set validator.version=${OPERATOR_VERSION}"
fi

OPERATOR_OPTIONS="${OPERATOR_OPTIONS} --set operator.defaultRuntime=${CONTAINER_RUNTIME}"
fi

if [[ "${USE_VALUES_FILE}" == "true" ]]; then
Expand Down
Loading