Skip to content

Quote packages in pip install to avoid shell expansion #529

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
samcmill merged 3 commits into from
Dec 19, 2025
Merged

Quote packages in pip install to avoid shell expansion #529

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
45599cc
Quote packages in pip install to avoid shell expansion
dylan-eustice Dec 19, 2025
6a9ef44
Update unit tests to expect quotes
dylan-eustice Dec 19, 2025
ff40172
Use shlex_quotes from six.moves instead of f-string and update unit t…
dylan-eustice Dec 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion hpccm/building_blocks/pip.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@
from packaging.version import Version
import logging
import posixpath
from six.moves import shlex_quote

import hpccm.config
import hpccm.templates.rm
Expand Down Expand Up @@ -165,6 +166,8 @@ def __instructions(self):
posixpath.basename(self.__requirements))]))

if self.__packages:
# Quote the packages to avoid shell expansion
quoted_packages = [shlex_quote(pkg) for pkg in self.__packages]
cmds.append('{0} install {1}'.format(self.__pip,
' '.join(self.__packages)))
' '.join(quoted_packages)))
self += shell(commands=cmds)
9 changes: 9 additions & 0 deletions test/test_pip.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -166,3 +166,12 @@ def test_upgrade(self):
rm -rf /var/lib/apt/lists/*
RUN pip --no-cache-dir install --upgrade "pip < 21.0" && \
pip --no-cache-dir install hpccm''')

@ubuntu
@docker
def test_package_with_version(self):
"""package with version specifier is quoted"""
p = pip(ospackages=[], packages=['hpccm>=1.0'])
self.assertEqual(str(p),
r"""# pip
RUN pip --no-cache-dir install 'hpccm>=1.0'""")
Loading