Skip to content

Commit 37f3c2d

Browse files
authored
fix(nvlink): Multicast group limit attribute, when creating a partiti… (#2681)
…on, needs to be a multiple of 4. <!-- Describe what this PR does --> GB200 NVL partition multicast group limit setting has an additional constraint that the value must be 0 or a multiple of 4. The formula previously used to calculate the default limit was evaluating to a value of 18. This PR rounds it down to nearest multiple of 4. NMX-C simulator used for pre-integration testing does not check for this contraint. ## Related issues <!-- Refer to existing GitHub issues here --> ## Type of Change <!-- Check one that best describes this PR --> - [ ] **Add** - New feature or capability - [ ] **Change** - Changes in existing functionality - [ X] **Fix** - Bug fixes - [ ] **Remove** - Removed features or deprecated functionality - [ ] **Internal** - Internal changes (refactoring, tests, docs, etc.) ## Breaking Changes <!-- If checked, describe the breaking changes and migration steps --> <!-- Breaking changes are not generally permitted, please discuss on a GitHub discussion or with the development team if you believe you need to break a backward compatibility guarantee --> - [ ] **This PR contains breaking changes** ## Testing <!-- How was this tested? Check all that apply --> - [ ] Unit tests added/updated - [ ] Integration tests added/updated - [ X] Manual testing performed - [ ] No testing required (docs, internal refactor, etc.) ## Additional Notes <!-- Any additional context, deployment notes, or reviewer guidance --> Signed-off-by: Roopesh Tamma <rtamma@nvidia.com>
1 parent 6d36a43 commit 37f3c2d

1 file changed

Lines changed: 4 additions & 3 deletions

File tree

crates/nvlink-manager/src/lib.rs

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -62,9 +62,10 @@ use tracing::Instrument;
6262
/// Default NMX-M instance identifier for credentials and client lookup when none is specified.
6363
pub const DEFAULT_NMX_M_NAME: &str = "default";
6464

65-
/// Multicast groups limit for new NMX-C partitions. Assuming at most 2 partitions per tray and
66-
// 18 tray default partitions, this is set to floor(1024 / (36+18)).
67-
const NMX_C_PARTITION_MULTICAST_GROUPS_LIMIT: u32 = 1024 / (36 + 18);
65+
/// Multicast groups limit for new NMX-C partitions. Must be a multiple of 4. Assuming at most 2
66+
/// partitions per tray and 18 tray default partitions, this is floor(1024 / (36+18)) rounded down
67+
/// to the nearest multiple of 4.
68+
const NMX_C_PARTITION_MULTICAST_GROUPS_LIMIT: u32 = 16;
6869

6970
fn rack_id_from_chassis_snapshots(
7071
chassis_snapshots: &[&ManagedHostStateSnapshot],

0 commit comments

Comments
 (0)