fix(nvlink): Multicast group limit attribute, when creating a partiti… (#2681)

…on, needs to be a multiple of 4.

<!-- Describe what this PR does -->
GB200 NVL partition multicast group limit setting has an additional
constraint that the value must be 0 or a multiple of 4. The formula
previously used to calculate the default limit was evaluating to a value
of 18. This PR rounds it down to nearest multiple of 4.
NMX-C simulator used for pre-integration testing does not check for this
contraint.

## Related issues
<!-- Refer to existing GitHub issues here -->

## Type of Change
<!-- Check one that best describes this PR -->
- [ ] **Add** - New feature or capability
- [ ] **Change** - Changes in existing functionality
- [ X] **Fix** - Bug fixes
- [ ] **Remove** - Removed features or deprecated functionality
- [ ] **Internal** - Internal changes (refactoring, tests, docs, etc.)

## Breaking Changes
<!-- If checked, describe the breaking changes and migration steps -->
<!-- Breaking changes are not generally permitted, please discuss on a
GitHub discussion or with the development team if you believe you need
to break a backward compatibility guarantee -->
- [ ] **This PR contains breaking changes**

## Testing
<!-- How was this tested? Check all that apply -->
- [ ] Unit tests added/updated
- [ ] Integration tests added/updated
- [ X] Manual testing performed
- [ ] No testing required (docs, internal refactor, etc.)

## Additional Notes
<!-- Any additional context, deployment notes, or reviewer guidance -->

Signed-off-by: Roopesh Tamma <rtamma@nvidia.com>
Signed-off-by: Thomas McRoberts <tmcroberts@nvidia.com>

Author: rtamma-nv

crates/api/src/tests/nvl_instance.rs

@@ -52,9 +52,8 @@ use rpc::forge::TenantState;
 use rpc::forge::forge_server::Forge;
 
 use crate::tests::common;
-use crate::tests::common::api_fixtures::TEST_SITE_PREFIXES;
-use crate::tests::common::api_fixtures::TestEnvOverrides;
 use crate::tests::common::api_fixtures::nvl_logical_partition::NvlLogicalPartitionFixture;
+use crate::tests::common::api_fixtures::{TEST_SITE_PREFIXES, TestEnvOverrides};
 use crate::tests::common::mac_address_pool::{
     EXPECTED_SWITCH_BMC_MAC_ADDRESS_POOL, EXPECTED_SWITCH_NVOS_MAC_ADDRESS_POOL,
 };

crates/nvlink-manager/src/lib.rs

@@ -62,9 +62,10 @@ use tracing::Instrument;
 /// Default NMX-M instance identifier for credentials and client lookup when none is specified.
 pub const DEFAULT_NMX_M_NAME: &str = "default";
 
-/// Multicast groups limit for new NMX-C partitions. Assuming at most 2 partitions per tray and
-// 18 tray default partitions, this is set to floor(1024 / (36+18)).
-const NMX_C_PARTITION_MULTICAST_GROUPS_LIMIT: u32 = 1024 / (36 + 18);
+/// Multicast groups limit for new NMX-C partitions. Must be a multiple of 4. Assuming at most 2
+/// partitions per tray and 18 tray default partitions, this is floor(1024 / (36+18)) rounded down
+/// to the nearest multiple of 4.
+const NMX_C_PARTITION_MULTICAST_GROUPS_LIMIT: u32 = 16;
 
 fn rack_id_from_chassis_snapshots(
     chassis_snapshots: &[&ManagedHostStateSnapshot],