change(api,dhcp): new proto types, migrations & dual-stack NetworkDef… (#2672)

<!-- Describe what this PR does -->

Adds the additive proto, model, and schema surface needed for the IPv6
DHCP milestone without enabling DHCPv6 serving yet.

This PR is intended to be additive and inert for DHCPv4 behavior. The
new wire/config/schema fields are present for later milestones, but
DHCPv6 request handling and Kea/DPU DHCPv6 serving are not enabled here.

Closes #2381.

## Related issues
<!-- Refer to existing GitHub issues here -->
#2381

## Type of Change
<!-- Check one that best describes this PR -->
- [ ] **Add** - New feature or capability
- [ ] **Change** - Changes in existing functionality
- [ ] **Fix** - Bug fixes
- [ ] **Remove** - Removed features or deprecated functionality
- [x] **Internal** - Internal changes (refactoring, tests, docs, etc.)

## Breaking Changes
<!-- If checked, describe the breaking changes and migration steps -->
<!-- Breaking changes are not generally permitted, please discuss on a
GitHub discussion or with the development team if you believe you need
to break a backward compatibility guarantee -->
- [ ] **This PR contains breaking changes**

## Testing
<!-- How was this tested? Check all that apply -->
- [x] Unit tests added/updated
- [x] Integration tests added/updated
- [ ] Manual testing performed
- [ ] No testing required (docs, internal refactor, etc.)

## Additional Notes
<!-- Any additional context, deployment notes, or reviewer guidance -->

Author: bcavnvidia

crates/agent/src/dhcp_server_grpc_client.rs

@@ -21,7 +21,7 @@ pub mod proto {
 
 use carbide_rpc_utils::dhcp::{
     DhcpConfig as ModelDhcpConfig, HostConfig as ModelHostConfig,
-    InterfaceInfo as ModelInterfaceInfo,
+    InterfaceInfo as ModelInterfaceInfo, InterfaceInfoV6 as ModelInterfaceInfoV6,
 };
 use carbide_uuid::machine::MachineInterfaceId;
 use proto::dhcp_server_control_client::DhcpServerControlClient;
@@ -47,6 +47,28 @@ impl From<ModelDhcpConfig> for proto::DhcpConfig {
                 .collect(),
             carbide_provisioning_server_ipv4: c.carbide_provisioning_server_ipv4.to_string(),
             carbide_dhcp_server: c.carbide_dhcp_server.to_string(),
+            carbide_nameservers_v6: c
+                .carbide_nameservers_v6
+                .iter()
+                .map(|ip| ip.to_string())
+                .collect(),
+            carbide_ntpservers_v6: c
+                .carbide_ntpservers_v6
+                .iter()
+                .map(|ip| ip.to_string())
+                .collect(),
+            carbide_dhcp_server_v6: c.carbide_dhcp_server_v6.map(|ip| ip.to_string()),
+            dhcpv6_preferred_lifetime_secs: c.dhcpv6_preferred_lifetime_secs,
+            dhcpv6_valid_lifetime_secs: c.dhcpv6_valid_lifetime_secs,
+        }
+    }
+}
+
+impl From<ModelInterfaceInfoV6> for proto::InterfaceInfoV6 {
+    fn from(i: ModelInterfaceInfoV6) -> Self {
+        proto::InterfaceInfoV6 {
+            address: i.address.map(|ip| ip.to_string()),
+            prefix: i.prefix,
         }
     }
 }
@@ -60,6 +82,7 @@ impl From<ModelInterfaceInfo> for proto::InterfaceInfo {
             fqdn: i.fqdn,
             booturl: i.booturl,
             mtu: i.mtu,
+            ipv6: i.ipv6.map(Into::into),
         }
     }
 }

crates/agent/src/ethernet_virtualization.rs

@@ -3463,6 +3463,7 @@ mod tests {
             rebinding_time_secs: 432000,
             carbide_api_url: None,
             carbide_dhcp_server: Ipv4Addr::from([10, 217, 5, 39]),
+            ..Default::default()
         };
 
         let mut network_config = rpc::ManagedHostNetworkConfigResponse {
@@ -3656,6 +3657,7 @@ mod tests {
             rebinding_time_secs: 432000,
             carbide_api_url: None,
             carbide_dhcp_server: Ipv4Addr::from([10, 217, 5, 39]),
+            ..Default::default()
         };
         let dhcp_contents = super::read_limited(g.path())?;
         assert!(dhcp_contents.contains("vlan196"));

crates/api-core/src/cfg/README.md

@@ -34,7 +34,7 @@ applicable.
 | `listen_mode` | `ListenMode` | `Tls` | Transport mode: `plaintext_http1`, `plaintext_http2`, or `tls`. |
 | `auth` | `Option<AuthConfig>` | — | Authentication/authorization settings (see [AuthConfig](#authconfig)). |
 | `pools` | `Option<HashMap<String, ResourcePoolDef>>` | — | Resource pools that allocate IPs, VNIs, etc. Required but `Option` for partial-config merging. |
-| `networks` | `Option<HashMap<String, NetworkDefinition>>` | — | Networks created at startup. Alternative: `CreateNetworkSegment` gRPC. |
+| `networks` | `Option<HashMap<String, NetworkDefinition>>` | — | Networks created at startup. Alternative: `CreateNetworkSegment` gRPC. `NetworkDefinition` supports dual-stack seed-time segments with optional `prefix_v6` and `dhcpv6_link_address`; config edits do not retrofit prefixes onto an already-seeded segment because seed definitions are snapshotted on first create. |
 | `dpu_ipmi_tool_impl` | `Option<String>` | — | IPMI tool implementation for DPU power control (`"prod"` or `"fake"`). |
 | `dpu_ipmi_reboot_attempts` | `Option<u32>` | — | Retry count when IPMI errors during DPU reboot. |
 | `bmc_session_lockout_threshold` | `u32` | `3` | Consecutive BMC HTTP 401/403 responses before session-token login attempts stop for that BMC. |

crates/api-core/src/cfg/file.rs

@@ -3830,7 +3830,9 @@ firmware_url = "https://firmware.example.com/fw-b.bin"
             &NetworkDefinition {
                 segment_type: NetworkDefinitionSegmentType::Admin,
                 prefix: "172.20.0.0/24".parse().unwrap(),
+                prefix_v6: None,
                 gateway: "172.20.0.1".parse().unwrap(),
+                dhcpv6_link_address: None,
                 mtu: 9000,
                 reserve_first: 5,
                 allocation_strategy: Default::default(),
@@ -3843,7 +3845,9 @@ firmware_url = "https://firmware.example.com/fw-b.bin"
             &NetworkDefinition {
                 segment_type: NetworkDefinitionSegmentType::Underlay,
                 prefix: "172.99.0.0/26".parse().unwrap(),
+                prefix_v6: None,
                 gateway: "172.99.0.1".parse().unwrap(),
+                dhcpv6_link_address: None,
                 mtu: 1500,
                 reserve_first: 5,
                 allocation_strategy: Default::default(),
@@ -3856,7 +3860,9 @@ firmware_url = "https://firmware.example.com/fw-b.bin"
             &NetworkDefinition {
                 segment_type: NetworkDefinitionSegmentType::HostInband,
                 prefix: "10.217.18.192/30".parse().unwrap(),
+                prefix_v6: None,
                 gateway: "10.217.18.193".parse().unwrap(),
+                dhcpv6_link_address: None,
                 mtu: 1500,
                 reserve_first: 1,
                 allocation_strategy: Default::default(),

crates/api-core/src/db_init.rs

@@ -227,6 +227,7 @@ pub async fn ensure_static_assignments_segment(
         prefixes: vec![NewNetworkPrefix {
             prefix: "169.254.254.254/32".parse().unwrap(),
             gateway: None,
+            dhcpv6_link_address: None,
             num_reserved: 1,
         }],
         vlan_id: None,

crates/api-core/src/dhcp/discover.rs

@@ -82,6 +82,8 @@ async fn handle_overlay_from_dpa(
         fqdn: String::new(),
         prefix,
         ntp_servers: ntp_servers.iter().map(ToString::to_string).collect(),
+        dhcpv6_preferred_lifetime_secs: None,
+        dhcpv6_valid_lifetime_secs: None,
     })))
 }
 
@@ -123,6 +125,8 @@ async fn handle_underlay_from_dpa(
         fqdn: String::new(),
         prefix,
         ntp_servers: ntp_servers.iter().map(ToString::to_string).collect(),
+        dhcpv6_preferred_lifetime_secs: None,
+        dhcpv6_valid_lifetime_secs: None,
     })))
 }
 

crates/api-core/src/handlers/machine_interface_address.rs

@@ -218,6 +218,7 @@ pub async fn find_interface_addresses(
             allocation_type: match a.allocation_type {
                 AllocationType::Dhcp => "dhcp".to_string(),
                 AllocationType::Static => "static".to_string(),
+                AllocationType::Slaac => "slaac".to_string(),
             },
         })
         .collect();

crates/api-core/src/network_segment/allocate.rs

@@ -182,6 +182,7 @@ impl PrefixAllocator {
             prefixes: vec![NewNetworkPrefix {
                 prefix,
                 gateway,
+                dhcpv6_link_address: None,
                 num_reserved: 0,
             }],
             vlan_id: None,
@@ -240,6 +241,7 @@ impl PrefixAllocator {
             &[NewNetworkPrefix {
                 prefix,
                 gateway,
+                dhcpv6_link_address: None,
                 num_reserved: 0,
             }],
         )

crates/api-core/src/setup.rs

@@ -1590,8 +1590,10 @@ mod tests {
         NetworkDefinition {
             segment_type,
             prefix,
+            prefix_v6: None,
             // Test helper placeholder; callers under test do not use this as a routable gateway.
             gateway: prefix.network(),
+            dhcpv6_link_address: None,
             mtu: 0,
             reserve_first: 0,
             allocation_strategy: Default::default(),

crates/api-core/src/tests/machine_discovery.rs

@@ -197,6 +197,9 @@ async fn test_discover_dpu_by_source_ip(
             circuit_id: None,
             remote_id: None,
             desired_address: None,
+            address_family: None,
+            message_kind: None,
+            duid: None,
         }))
         .await
         .unwrap()
@@ -237,6 +240,9 @@ async fn test_discover_dpu_not_create_machine(
             circuit_id: None,
             remote_id: None,
             desired_address: None,
+            address_family: None,
+            message_kind: None,
+            duid: None,
         }))
         .await
         .unwrap()