Skip to content

ci: release/* workflow runs only on tags #2340

Description

@nv-dmendoza

Is this a new feature, an enhancement, or a change to existing functionality?

Enhancement

How would you describe the priority of this feature request

Medium

Please provide a clear description of problem this feature solves

There is a current race condition where the tag needs to exist for the correct build version to be generated. By moving the release branches to only run on tags, we remove the need for this race condition and can stack changes in a release branch before triggering the ci workflow to build the final artifacts. This matches how we currently need a few cherry-picked changes at a time in order to create a new patch or RC.

Feature Description

From a maintainer perspective, I want to be able to trigger the CI pipeline via tag creation and not on commit so the build version generated is based on my tag. This should only apply to workflows on release/* branches.

Describe your ideal solution

CI workflow changed so that the workflow only runs on tags when on a release/* branch.

Describe any alternatives you have considered

Alternatives included adding a tag stage before the prepare job but that introduces a few issues:

  • bot tagging instead of user tagging (not as desirable)
  • requires extra tagging state logic (if in rc, tag as rc+1 | if <condition> promote from rc to release | etc.)
  • resource waste - it's common we need a few cherry-pick commits before we want the pipeline to run and give artifacts, the intermediate commits don't need to be built and waste resources to build.

Additional context

No response

Code of Conduct

  • I agree to follow NCX Infra Controller's Code of Conduct
  • I have searched the open feature requests and have found no duplicates for this feature request

Metadata

Metadata

Labels

infraRelated to internal build or ci/cd infrastructure

Type

Fields

No fields configured for Task.

Projects

Status
Closed

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions