Skip to content

Fix minor issues in CONTRIBUTING.md#881

Open
acosmicflamingo wants to merge 1 commit into
NVIDIA:mainfrom
acosmicflamingo:fix-contributing-docs
Open

Fix minor issues in CONTRIBUTING.md#881
acosmicflamingo wants to merge 1 commit into
NVIDIA:mainfrom
acosmicflamingo:fix-contributing-docs

Conversation

@acosmicflamingo
Copy link
Copy Markdown

@acosmicflamingo acosmicflamingo commented May 8, 2026

Fixes #880

  • Modify the CLA hyperlink to point to the right URL

  • Update 'pip install' commands to support dependency groups usage in pyproject.toml

    • test-cu12 and test-cu13 were moved from 'optional-dependencies' section to 'dependency-groups' section

@copy-pr-bot
Copy link
Copy Markdown

copy-pr-bot Bot commented May 8, 2026

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

* Modify CLA hyperlink to point to the right URL

* Update 'pip install' commands to support dependency groups
  usage in pyproject.toml
  > test-cu12 and test-cu13 were moved from 'optional-dependencies'
    section to 'dependency-groups' section

* Explicitly pin cuda-bindings dependency in test-cu12 and test-cu13
  dependency groups
@acosmicflamingo acosmicflamingo force-pushed the fix-contributing-docs branch from 17b6be8 to b690a3e Compare May 8, 2026 16:05
@acosmicflamingo
Copy link
Copy Markdown
Author

Also found issue with trying to install test dependencies using CUDA 12.x; cuda-bindings needs to be pinned in pyproject.toml as well.

@acosmicflamingo
Copy link
Copy Markdown
Author

/ok to test

@acosmicflamingo acosmicflamingo changed the title Fix minor issues in CONTRIBUTING.md (#880) Fix minor issues in CONTRIBUTING.md May 9, 2026
@acosmicflamingo
Copy link
Copy Markdown
Author

While running tests for the test_extending module, I noticed this failure:

>   ???
E   cuda.bindings.nvjitlink.nvJitLinkError: ERROR_OUTDATED_LIBRARY (14)
E   nvJitLink error log: ERROR NVVM_ERROR_INVALID_INPUT (4) in nvvmAddNVVMContainerToProgram, may need newer version of nvJitLink library
E   

It appears to be something others have encountered: numba/numba#10353. After reading, I noticed that in my pip environment that was generated from test-cu13, that nvidia-nvjitlink dependency was missing (and installing it fixes the issue).

I suppose this shouldn't be a surprise because it's listed as an optional dependency in pyproject.toml, I'm wondering whether the command in this PR needs to be updated further to look like this pip install -e ".[cu13]" --group test-cu13 or have test-cu13 automatically include cu13 and then the command could be pip install -e . --group test-cu13.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[DOC] Minor tweaks to CONTRIBUTING.md

1 participant