Skip to content

[nri-plugin] support injection of management CDI devices in multiple namespaces#1901

Merged
tariq1890 merged 1 commit into
mainfrom
nri-additional-namespaces
Jun 30, 2026
Merged

[nri-plugin] support injection of management CDI devices in multiple namespaces#1901
tariq1890 merged 1 commit into
mainfrom
nri-additional-namespaces

Conversation

@tariq1890

Copy link
Copy Markdown
Contributor

This commit exposes a new CLI flag so that users can specify additional namespaces that are authorised for management CDI device injection via the NRI plugin. Currently, users can only inject management CDI devices to containers/pods that are in the same namespace as that of the toolkit pod. With this change, users can specify can additional namespaces whose pods may need management CDI device access.

@tariq1890 tariq1890 requested a review from cdesiniotis June 24, 2026 01:27
@tariq1890 tariq1890 self-assigned this Jun 24, 2026
@coveralls

coveralls commented Jun 24, 2026

Copy link
Copy Markdown

Coverage Report for CI Build 28411868985

Coverage increased (+0.08%) to 43.629%

Details

  • Coverage increased (+0.08%) from the base build.
  • Patch coverage: 6 uncovered changes across 2 files (3 of 9 lines covered, 33.33%).
  • No coverage regressions found.

Uncovered Changes

File Changed Covered %
cmd/nvidia-ctk-installer/container/runtime/nri/plugin.go 7 3 42.86%
cmd/nvidia-ctk-installer/main.go 2 0 0.0%

Coverage Regressions

No coverage regressions found.


Coverage Stats

Coverage Status
Relevant Lines: 15013
Covered Lines: 6550
Line Coverage: 43.63%
Coverage Strength: 0.49 hits per line

💛 - Coveralls

@tariq1890 tariq1890 force-pushed the nri-additional-namespaces branch 2 times, most recently from 17e30c4 to e55b49b Compare June 30, 2026 00:28
…namespaces

This commit exposes a new CLI flag so that users can specify additional
namespaces that are authorised for management CDI device injection via the
NRI plugin. Currently, users can only inject management CDI devices to
containers/pods that are in the same namespace as that of the toolkit pod.
With this change, users can specify can additional namespaces whose pods
may need management CDI device access.

Signed-off-by: Tariq Ibrahim <tibrahim@nvidia.com>
@tariq1890 tariq1890 force-pushed the nri-additional-namespaces branch from e55b49b to e950019 Compare June 30, 2026 00:29
@tariq1890 tariq1890 enabled auto-merge June 30, 2026 00:56
@tariq1890 tariq1890 merged commit 17d5e56 into main Jun 30, 2026
20 checks passed
@tariq1890 tariq1890 deleted the nri-additional-namespaces branch June 30, 2026 01:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants