[wsl2] discover all .so, .bin, and .dll files at nvidia driver store path#1890
Draft
cdesiniotis wants to merge 1 commit into
Draft
[wsl2] discover all .so, .bin, and .dll files at nvidia driver store path#1890cdesiniotis wants to merge 1 commit into
cdesiniotis wants to merge 1 commit into
Conversation
cdesiniotis
force-pushed
the
wsl2-discover-additional-libraries
branch
from
fd3d76b to
daef5be
Compare
Coverage Report for CI Build 27727799573Coverage decreased (-0.2%) to 43.321%Details
Uncovered Changes
Coverage RegressionsNo coverage regressions found. Coverage Stats
💛 - Coveralls |
cdesiniotis
force-pushed
the
wsl2-discover-additional-libraries
branch
from
daef5be to
14a952a
Compare
…path We currently define a hardcoded list of required files that must be discovered at the driver store. This commit extends this logic to also search for additional .so, .bin, and .dll files that may be present in the nvidia driver store path. fixes NVIDIA#1864 Signed-off-by: Christopher Desiniotis <cdesiniotis@nvidia.com>
cdesiniotis
force-pushed
the
wsl2-discover-additional-libraries
branch
from
14a952a to
fef1e4b
Compare
cdesiniotis
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We currently define a hardcoded list of required files that must be discovered at the driver store. This commit extends this logic to also search for additional .so, .bin, and .dll files that may be present in the nvidia driver store path.
fixes #1864
Testing
Before this change, generating a CDI spec would discover the following:
After this change, the below gets discovered. Notably, 13 additional libraries are discovered and added to the generated CDI spec:
libcudadebugger.so.1 libnvcuvid.so.1 libnvdxdlkernels.so libnvidia-encode.so.1 libnvidia-gpucomp.so libnvidia-ngx.so.1 libnvidia-nvvm.so.4 libnvidia-nvvm70.so.4 libnvidia-opticalflow.so.1 libnvidia-tileiras.so libnvoptix_loader.so.1 libnvvamanager.so.1 libnvwgf2umx.so. 5 additional '.bin' files are discovered and all '.dll' files in the driver store are included as well.