Skip to content

Register Data Designer skill#108

Merged
mosheabr merged 3 commits into
NVIDIA:mainfrom
johnnygreco:johnny/register-data-designer-skill
Jun 2, 2026
Merged

Register Data Designer skill#108
mosheabr merged 3 commits into
NVIDIA:mainfrom
johnnygreco:johnny/register-data-designer-skill

Conversation

@johnnygreco
Copy link
Copy Markdown
Contributor

@johnnygreco johnnygreco commented May 28, 2026

Onboarding type

  • New product onboarding (new components.d/<slug>.yml file)
  • Other (catalog change, README fix, infrastructure, etc.)

For new product onboarding — author affirmations

By submitting this PR, I confirm on behalf of my team:

  • Skills cleared for open source release per NVIDIA's internal IP review process (six-question check, all answers affirmative)
  • License selected: Apache 2.0
  • No new license or new third-party component introduced beyond what the source repo already carries
  • Source repo is public and under an NVIDIA-owned GitHub org
  • .agents/skills/ or skills/ path used for new entries (or existing path retained for legacy entries per components.d/<slug>.yml)

NVIDIA contributors: see the internal onboarding guide for the IP review process details and license selection.

Reviewer checklist (OSS Skills PIC)

  • Author confirmations above are checked
  • components.d/<slug>.yml entry valid (required fields, unique catalog_dir, path exists in source repo, filename slug matches name)
  • SKILL.md frontmatter spec-compliant (at least one sampled)
  • No new license or third-party dependency requiring OSRB filing

All PRs

  • All commits signed off with DCO (git commit -s).
    If you forgot, run git rebase --signoff origin/main && git push --force-with-lease to retroactively sign all commits in your branch.

Other context (for non-onboarding PRs)

Registers the Data Designer skill from NVIDIA-NeMo/DataDesigner at skills/data-designer/ into the NVIDIA skills catalog as data-designer.

Validation performed locally:

  • Parsed all components.d/*.yml files with PyYAML.
  • Confirmed catalog_dir: data-designer is unique.
  • Confirmed NVIDIA-NeMo/DataDesigner is public and the source path exists on main.
  • Ran git diff --check.

Signed-off-by: Johnny Greco <jogreco@nvidia.com>
@johnnygreco johnnygreco marked this pull request as ready for review May 29, 2026 16:15
Signed-off-by: Johnny Greco <jogreco@nvidia.com>
Signed-off-by: Johnny Greco <jogreco@nvidia.com>
@calliente
Copy link
Copy Markdown
Collaborator

PR failing CI pipeline, left comments on NVIDIA-NeMo/DataDesigner#718

@johnnygreco
Copy link
Copy Markdown
Contributor Author

@calliente – should be good to go in the Data Designer repo. That PR has been merged after a successful NVSkills CI run

@mosheabr mosheabr merged commit 1b8c564 into NVIDIA:main Jun 2, 2026
2 checks passed
mosheabr added a commit that referenced this pull request Jun 2, 2026
…numeric-hdf5)

Cherry-picked from automated/sync-skills sync run 26844622126.
Lands only skills whose skill.oms.sig was refreshed alongside content
changes. The 15 still-drifted skills (VSS x 13, nemoclaw-user-reference,
nemo-automodel-distributed-training) remain held until their teams
re-sign on the source repos.

CLEAN (24 dirs):
- data-designer (new — PR #108 source content)
- cupynumeric-hdf5 (Manolis re-signed)
- 22 nemo-mbridge-* (Chen Cui's team re-signed)

README regenerated.

Signed-off-by: Moshe Abramovitch <moshea@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants