Skip to content

Commit 206f238

Browse files
committed
Silencing clang-tidy warnings
- Silencing `readability-static-accessed-through-instance` by removing static from function declaration - Silencing "Assigned value is garbage or undefined": - Properly initialize vtable - Disabling some code when run under clang-tidy
1 parent e8ef023 commit 206f238

2 files changed

Lines changed: 7 additions & 5 deletions

File tree

include/exec/any_sender_of.hpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -445,7 +445,7 @@ namespace exec {
445445
}
446446

447447
__t(const __t& __other)
448-
requires(_Copyable)
448+
requires(_Copyable) : __vtable_(__other.__vtable_)
449449
{
450450
(*__other.__vtable_)(__copy_construct, this, __other);
451451
}
@@ -460,7 +460,7 @@ namespace exec {
460460
return *this;
461461
}
462462

463-
__t(__t&& __other) noexcept {
463+
__t(__t&& __other) noexcept : __vtable_(__other.__vtable_) {
464464
(*__other.__vtable_)(__move_construct, this, static_cast<__t&&>(__other));
465465
}
466466

include/exec/task.hpp

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -320,16 +320,16 @@ namespace exec {
320320

321321
private:
322322
struct __final_awaitable {
323-
static constexpr auto await_ready() noexcept -> bool {
323+
constexpr auto await_ready() noexcept -> bool {
324324
return false;
325325
}
326326

327-
static auto await_suspend(__coro::coroutine_handle<__promise> __h) noexcept
327+
auto await_suspend(__coro::coroutine_handle<__promise> __h) noexcept
328328
-> __coro::coroutine_handle<> {
329329
return __h.promise().continuation().handle();
330330
}
331331

332-
static void await_resume() noexcept {
332+
void await_resume() noexcept {
333333
}
334334
};
335335

@@ -369,6 +369,7 @@ namespace exec {
369369
this->__data_.template emplace<1>(std::current_exception());
370370
}
371371

372+
#ifndef __clang_analyzer__
372373
template <sender _Awaitable>
373374
requires __scheduler_provider<_Context>
374375
auto await_transform(_Awaitable&& __awaitable) noexcept -> decltype(auto) {
@@ -396,6 +397,7 @@ namespace exec {
396397
__context_->set_scheduler(__box.__sched_);
397398
return as_awaitable(schedule(__box.__sched_), *this);
398399
}
400+
#endif
399401

400402
template <class _Awaitable>
401403
auto await_transform(_Awaitable&& __awaitable) noexcept -> decltype(auto) {

0 commit comments

Comments
 (0)