fix the attributes of the let_ senders

Author: ericniebler

include/stdexec/__detail/__completion_behavior.hpp

@@ -34,9 +34,10 @@ namespace STDEXEC
   // __get_completion_behavior
   struct __completion_behavior
   {
-    //private:
+   // private:
     template <__completion_tag _Tag>
     friend struct __get_completion_behavior_t;
+    friend struct __completion_info;
 
     enum __flag : std::uint8_t
     {
@@ -63,6 +64,46 @@ namespace STDEXEC
       __unknown = __not_affine_ | __async_ | __inline_
     };
 
+    // For use when computing the completion behavior of two senders when run in parallel.
+    //
+    // __asynchronous        | __asynchronous_affine   => __async_                            (aka __asynchronous)
+    // __asynchronous        | __inline_completion     => __async_ | __inline_ | __not_affine (aka __unknown)
+    // __asynchronous_affine | __inline_completion     => __async_ | __inline_
+    STDEXEC_ATTRIBUTE(nodiscard, always_inline, host, device)
+    friend constexpr auto operator|(__behavior __left, __behavior __right) noexcept -> __behavior
+    {
+      return __behavior(std::uint8_t(__left) | std::uint8_t(__right));
+    }
+
+    STDEXEC_ATTRIBUTE(always_inline, host, device)
+    friend constexpr auto operator|=(__behavior& __left, __behavior __right) noexcept -> __behavior&
+    {
+      return (__left = (__left | __right));
+    }
+
+    // For use when computing the completion behavior of two senders when run in sequence.
+    STDEXEC_ATTRIBUTE(nodiscard, always_inline, host, device)
+    friend constexpr auto operator&(__behavior __left, __behavior __right) noexcept -> __behavior
+    {
+      // Two senders in sequence can only complete inline if both senders can complete
+      // inline.
+      auto const __possibly_inline = std::uint8_t(__left) & std::uint8_t(__right) & __inline_;
+      // Two senders in sequence can complete in a different context if either sender can
+      // complete in a different context.
+      auto const __not_affine = (std::uint8_t(__left) | std::uint8_t(__right)) & __not_affine_;
+      // Two senders in sequence can complete asynchronously if either sender can complete
+      // asynchronously.
+      auto const __possibly_async = (std::uint8_t(__left) | std::uint8_t(__right)) & __async_;
+
+      return __behavior(__possibly_inline | __not_affine | __possibly_async);
+    }
+
+    STDEXEC_ATTRIBUTE(always_inline, host, device)
+    friend constexpr auto operator&=(__behavior& __left, __behavior __right) noexcept -> __behavior&
+    {
+      return (__left = (__left & __right));
+    }
+
     template <__behavior _CB>
     using __constant_t = std::integral_constant<__behavior, _CB>;
 
@@ -81,15 +122,37 @@ namespace STDEXEC
     static constexpr __asynchronous_affine_t __asynchronous_affine{};
     static constexpr __inline_completion_t   __inline_completion{};
 
-    // __asynchronous        | __asynchronous_affine   => __async_                            (aka __asynchronous)
-    // __asynchronous        | __inline_completion     => __async_ | __inline_ | __not_affine (aka __unknown)
-    // __asynchronous_affine | __inline_completion     => __async_ | __inline_
+   //private:
+    template <__behavior _CB>
+    static constexpr auto __reify() noexcept
+    {
+      if constexpr (_CB == __behavior::__asynchronous)
+        return __asynchronous;
+      else if constexpr (_CB == __behavior::__asynchronous_affine)
+        return __asynchronous_affine;
+      else if constexpr (_CB == __behavior::__inline_completion)
+        return __inline_completion;
+      else if constexpr (_CB == __behavior::__unknown)
+        return __unknown;
+      else
+        return __constant_t<_CB>{};
+    }
+
+   public:
+    // For use when computing the completion behavior of two senders when run in parallel.
     template <__behavior _Left, __behavior _Right>
     STDEXEC_ATTRIBUTE(nodiscard, always_inline, host, device)
     friend constexpr auto operator|(__constant_t<_Left>, __constant_t<_Right>) noexcept
     {
-      return __constant_t<static_cast<__behavior>(static_cast<std::uint8_t>(_Left)
-                                                  | static_cast<std::uint8_t>(_Right))>();
+      return __reify<_Left | _Right>();
+    }
+
+    // For use when computing the completion behavior of two senders when run in sequence.
+    template <__behavior _Left, __behavior _Right>
+    STDEXEC_ATTRIBUTE(nodiscard, always_inline, host, device)
+    friend constexpr auto operator&(__constant_t<_Left>, __constant_t<_Right>) noexcept
+    {
+      return __reify<_Left & _Right>();
     }
 
     template <__behavior _Left, __behavior _Right>
@@ -123,11 +186,10 @@ namespace STDEXEC
     struct __common_t
     {
       template <__behavior... _CSs>
-        requires(sizeof...(_CSs) > 0)
       STDEXEC_ATTRIBUTE(nodiscard, host, device)
       constexpr auto operator()(__constant_t<_CSs>... __cbs) const noexcept
       {
-        return (__cbs | ...);
+        return (__cbs | ... | __constant_t<__behavior(0)>());
       }
     };
 

include/stdexec/__detail/__completion_info.hpp

@@ -21,6 +21,7 @@
 #include "__completion_behavior.hpp"
 #include "__completion_signatures.hpp"
 #include "__meta.hpp"
+#include "__ranges.hpp"
 #include "__static_vector.hpp"
 #include "__typeinfo.hpp"
 
@@ -126,6 +127,54 @@ namespace STDEXEC
       }
     }();
 
+    template <class _Iterator>
+    struct __subrange
+    {
+      template <std::ranges::range Range>
+      constexpr __subrange(Range &&rng)
+        : __begin_(std::ranges::begin(rng))
+        , __end_(std::ranges::end(rng))
+      {}
+
+      constexpr auto begin() const noexcept -> _Iterator
+      {
+        return __begin_;
+      }
+
+      constexpr auto end() const noexcept -> _Iterator
+      {
+        return __end_;
+      }
+
+      [[nodiscard]]
+      constexpr auto size() const noexcept -> std::size_t
+      {
+        return std::size_t(std::distance(__begin_, __end_));
+      }
+
+      constexpr auto operator[](std::size_t __i) const noexcept -> std::iter_reference_t<_Iterator>
+      {
+        return *std::next(__begin_, __i);
+      }
+
+      _Iterator __begin_, __end_;
+    };
+
+    template <class Range>
+    STDEXEC_HOST_DEVICE_DEDUCTION_GUIDE
+    __subrange(Range &&) -> __subrange<std::ranges::iterator_t<Range>>;
+
+    template <std::ranges::forward_range auto _Range, class _Fn, class... _Args>
+    constexpr auto __range_apply(_Fn &&__fn, _Args &&...args) noexcept
+    {
+      auto __impl = [&]<std::size_t... _Is>(__indices<_Is...>)
+      {
+        return static_cast<_Fn &&>(__fn).template
+        operator()<(*std::ranges::next(_Range.begin(), _Is))...>(std::forward<_Args>(args)...);
+      };
+      return __impl(__make_indices<std::ranges::size(_Range)>());
+    }
+
     template <class _GetComplInfo>
     consteval auto __completion_sigs_from(_GetComplInfo) noexcept
     {
@@ -142,13 +191,31 @@ namespace STDEXEC
 
     template <class... _Sigs>
     [[nodiscard]]
-    consteval auto __to_array(completion_signatures<_Sigs...>) noexcept
+    consteval auto __reflection_of(completion_signatures<_Sigs...>) noexcept
     {
       using __array_t = __static_vector<__completion_info, sizeof...(_Sigs)>;
       auto __compls   = __array_t{__completion_info(__signature<_Sigs>)...};
       std::ranges::sort(__compls);
       return __compls;
     }
+
+    template <auto>
+    extern int __splice_v;
+
+    template <auto _Info>
+    using __splice_t = decltype(__splice_v<_Info>);
+
+    template <__same_as<__completion_info> auto _Info>
+    extern __fn_ptr_t<__tuple<__msplice<_Info.__signature>,
+                              __msplice<_Info.__domain>,
+                              __mconstant<_Info.__behavior>>>
+      __splice_v<_Info>;
+
+    template <std::ranges::forward_range auto _Info>
+      requires __same_as<std::ranges::range_value_t<decltype(_Info)>, __completion_info>
+    constexpr auto __splice_v<_Info> = __with_indices<_Info.size()>()(
+      []<std::size_t... _Is>() { return __fn_ptr_t<__tuple<__splice_t<_Info[_Is]>...>>(); });
+
   }  // namespace __cmplsigs
 }  // namespace STDEXEC
 

include/stdexec/__detail/__execution_fwd.hpp

@@ -174,6 +174,8 @@ namespace STDEXEC
   using scheduler_t       = scheduler_tag;
   using receiver_t        = receiver_tag;
 
+  struct __completion_info;
+
   template <class _Tag, class _Sndr, class... _Env>
   STDEXEC_ATTRIBUTE(nodiscard, always_inline, host, device)
   constexpr auto __get_completion_behavior() noexcept;

include/stdexec/__detail/__get_completion_signatures.hpp

@@ -431,7 +431,7 @@ namespace STDEXEC
     auto __cmplsigs = STDEXEC::get_completion_signatures<_Sender, _Env...>();
     STDEXEC_IF_OK(__cmplsigs)
     {
-      auto __cmplinfo = STDEXEC::__cmplsigs::__to_array(__cmplsigs);
+      auto __cmplinfo = STDEXEC::__cmplsigs::__reflection_of(__cmplsigs);
       std::ranges::for_each(__cmplinfo, &__completion_info::__populate<_Sender, _Env...>);
       return __cmplinfo;
     }