treat unused parameter as error

Signed-off-by: romintomasetti <romin.tomasetti@gmail.com>

Author: romintomasetti

CMakeLists.txt

@@ -226,7 +226,7 @@ add_library(stdexec_executable_flags INTERFACE)
 
 # Enable warnings
 target_compile_options(stdexec_executable_flags INTERFACE
-                       $<$<STREQUAL:${stdexec_compiler_frontend},GNU>:-Wall>
+                       $<$<STREQUAL:${stdexec_compiler_frontend},GNU>:-Wall;-Werror=unused-parameter>
                        $<$<STREQUAL:${stdexec_compiler_frontend},AppleClang>:-Wall>
                        $<$<STREQUAL:${stdexec_compiler_frontend},MSVC>:/W4>)
 

include/exec/start_now.hpp

@@ -89,7 +89,7 @@ namespace exec {
         __storage_base<_EnvId>* __stg_;
 
         template <class... _As>
-        void set_value(_As&&... __as) noexcept {
+        void set_value(_As&&...) noexcept {
           __stg_->__complete();
         }
 

include/exec/task.hpp

@@ -157,8 +157,8 @@ namespace exec {
     struct __default_awaiter_context {
       template <__scheduler_affinity _Affinity>
       explicit __default_awaiter_context(
-        __default_task_context_impl<_Affinity>& __self,
-        _ParentPromise& __parent) noexcept {
+        __default_task_context_impl<_Affinity>&,
+        _ParentPromise&) noexcept {
       }
     };
 
@@ -225,8 +225,8 @@ namespace exec {
     struct __default_awaiter_context<void> {
       template <__scheduler_affinity _Affinity, class _ParentPromise>
       explicit __default_awaiter_context(
-        __default_task_context_impl<_Affinity>& __self,
-        _ParentPromise& __parent) noexcept {
+        __default_task_context_impl<_Affinity>&,
+        _ParentPromise&) noexcept {
       }
 
       template <__scheduler_affinity _Affinity, __indirect_stop_token_provider _ParentPromise>

include/stdexec/__detail/__submit.hpp

@@ -135,7 +135,7 @@ namespace stdexec {
       : __result_(connect(static_cast<_Sender&&>(__sndr), static_cast<_Receiver&&>(__rcvr))) {
     }
 
-    void submit(_Sender&& __sndr, _Receiver&&) noexcept {
+    void submit(_Sender&&, _Receiver&&) noexcept {
       stdexec::start(__result_);
     }
 

test/exec/test_repeat_effect_until.cpp

@@ -168,7 +168,7 @@ namespace {
     const auto tid = std::this_thread::get_id();
     bool called{false};
     ex::sender auto snd = stdexec::on(
-      pool.get_scheduler(), ex::just() | ex::bulk(ex::par_unseq, 1024, [&](int index) noexcept {
+      pool.get_scheduler(), ex::just() | ex::bulk(ex::par_unseq, 1024, [&](int) noexcept {
                               if (tid == std::this_thread::get_id()) {
                                 failed = true;
                               }

test/exec/test_task.cpp

@@ -259,7 +259,7 @@ namespace {
 
   struct test_domain {
     template <sender_expr_for<then_t> _Sender>
-    static constexpr auto transform_sender(_Sender&& __sndr) noexcept {
+    static constexpr auto transform_sender(_Sender&&) noexcept {
       return just("goodbye"s);
     }
   };

test/test_common/senders.hpp

@@ -36,7 +36,7 @@ namespace {
     };
 
     template <class Receiver>
-    auto connect(Receiver rcvr) const noexcept {
+    auto connect(Receiver) const noexcept {
       return operation{};
     }
   };