SCC-5307: NYQL dropdown and banner#730
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
| { name: "issn", label: "ISSN" }, | ||
| { name: "lccn", label: "LCCN" }, | ||
| { name: "callnumber", label: "call number" }, | ||
| { name: "cql", label: "query" }, |
Contributor
There was a problem hiding this comment.
this label seems a little ambiguous. is this what the discovery API expects?
charmingduchess
approved these changes
Apr 22, 2026
Contributor
|
You mentioned offline that there might be some forthcoming error handling stuff to work out -- is that still TK? |
Collaborator
Author
yes thats in progress but this is working with the current error handling for now |
charmingduchess
approved these changes
Apr 23, 2026
Collaborator
Author
|
Not merging until series work is released from QA, this work is on train |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ticket:
This PR does the following:
** Query guide link won't work yet bc the libguides page doesn't exist, note to self to check before deployment
How has this been tested?
Accessibility concerns or updates
Checklist: