Skip to content

Commit 0e9a292

Browse files
authored
Merge pull request #354 from NYU-RTS/storage-finder-update-data-trim
storage finder update data trim
2 parents 8a9fb42 + 7157230 commit 0e9a292

4 files changed

Lines changed: 44 additions & 205 deletions

File tree

scripts/storage-finder-data-generator/MAINTENANCE.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ bun scripts/storage-finder-data-generator/generate.ts \
3131

3232
## Service fields
3333

34-
Field definitions live in `scripts/storage-finder-data-generator/config.ts` (`FIELD_DEFINITIONS`). They map sheet columns to service detail rows (Links, Use Case, Limitations, Permission Settings, Eligibility, Synchronous Access, Alumni Access, Backup). Adjust labels or formatters there if the sheet schema changes.
34+
Field definitions live in `scripts/storage-finder-data-generator/config.ts` (`FIELD_DEFINITIONS`). They map sheet columns to service detail rows (Links, Use Case, Limitations, Permission Settings, Eligibility, Alumni Access, Backup). Adjust labels or formatters there if the sheet schema changes.
3535

3636
## Naming and IDs
3737

scripts/storage-finder-data-generator/config.ts

Lines changed: 0 additions & 38 deletions
Original file line numberDiff line numberDiff line change
@@ -51,13 +51,6 @@ export const FIELD_DEFINITIONS: ServiceFieldDefinition[] = [
5151
weight: 8,
5252
formatter: (value) => toHtmlBlocks(value),
5353
},
54-
{
55-
fieldKey: "field_synchronous_access",
56-
column: "Synchronous Access",
57-
label: "Synchronous Access",
58-
weight: 9,
59-
formatter: (value) => toHtmlBlocks(value),
60-
},
6154
{
6255
fieldKey: "field_backup",
6356
column: "Backup",
@@ -244,37 +237,6 @@ export const FACET_CONFIGS: FacetConfig[] = [
244237
],
245238
fallback: "all",
246239
},
247-
{
248-
id: "synchronous-access",
249-
name: "Do you need synchronous or simultaneous access to your data?",
250-
description: null,
251-
column: "Synchronous Access",
252-
controlType: "radio",
253-
allowMultipleMatches: true,
254-
choices: [
255-
{
256-
id: "synchronous-access.yes",
257-
name: "Yes",
258-
weight: 0,
259-
},
260-
{
261-
id: "synchronous-access.no",
262-
name: "No",
263-
weight: 1,
264-
},
265-
],
266-
matchers: [
267-
{
268-
pattern: /\b(yes|users can edit|simultaneously)\b/i,
269-
choices: ["synchronous-access.yes"],
270-
},
271-
{
272-
pattern: /\bnot available\b/i,
273-
choices: ["synchronous-access.no"],
274-
},
275-
],
276-
fallback: "all",
277-
},
278240
{
279241
id: "storage-duration",
280242
name: "What is your storage duration need?",

src/data/storage-finder/facet-tree.json

Lines changed: 7 additions & 36 deletions
Original file line numberDiff line numberDiff line change
@@ -160,41 +160,12 @@
160160
}
161161
]
162162
},
163-
{
164-
"id": "synchronous-access",
165-
"name": "Do you need synchronous or simultaneous access to your data?",
166-
"control_type": "radio",
167-
"parent": "0",
168-
"weight": "8",
169-
"selected": false,
170-
"description": null,
171-
"choices": [
172-
{
173-
"id": "synchronous-access.yes",
174-
"name": "Yes",
175-
"control_type": "radio",
176-
"parent": "synchronous-access",
177-
"weight": "0",
178-
"selected": false,
179-
"description": null
180-
},
181-
{
182-
"id": "synchronous-access.no",
183-
"name": "No",
184-
"control_type": "radio",
185-
"parent": "synchronous-access",
186-
"weight": "1",
187-
"selected": false,
188-
"description": null
189-
}
190-
]
191-
},
192163
{
193164
"id": "storage-duration",
194165
"name": "What is your storage duration need?",
195166
"control_type": "radio",
196167
"parent": "0",
197-
"weight": "10",
168+
"weight": "8",
198169
"selected": false,
199170
"description": null,
200171
"choices": [
@@ -223,7 +194,7 @@
223194
"name": "What is the primary purpose for your storage?",
224195
"control_type": "checkbox",
225196
"parent": "0",
226-
"weight": "12",
197+
"weight": "10",
227198
"selected": false,
228199
"description": null,
229200
"choices": [
@@ -288,7 +259,7 @@
288259
"name": "What is your budget for storage?",
289260
"control_type": "radio",
290261
"parent": "0",
291-
"weight": "14",
262+
"weight": "12",
292263
"selected": false,
293264
"description": null,
294265
"choices": [
@@ -317,7 +288,7 @@
317288
"name": "What storage capacity do you need?",
318289
"control_type": "radio",
319290
"parent": "0",
320-
"weight": "16",
291+
"weight": "14",
321292
"selected": false,
322293
"description": null,
323294
"choices": [
@@ -355,7 +326,7 @@
355326
"name": "From where will the data be accessed?",
356327
"control_type": "checkbox",
357328
"parent": "0",
358-
"weight": "18",
329+
"weight": "16",
359330
"selected": false,
360331
"description": null,
361332
"choices": [
@@ -402,7 +373,7 @@
402373
"name": "Do you have any special requirements or restrictions?",
403374
"control_type": "checkbox",
404375
"parent": "0",
405-
"weight": "20",
376+
"weight": "18",
406377
"selected": false,
407378
"description": null,
408379
"choices": [
@@ -458,7 +429,7 @@
458429
"name": "What additional features do you need?",
459430
"control_type": "checkbox",
460431
"parent": "0",
461-
"weight": "22",
432+
"weight": "20",
462433
"selected": false,
463434
"description": null,
464435
"choices": [

0 commit comments

Comments
 (0)