Skip to content

Commit 67b506e

Browse files
authored
Merge pull request #394 from NYU-RTS/reviewdog-pr-review
reviewdog change reporter
2 parents 442a6a8 + ddc0239 commit 67b506e

1 file changed

Lines changed: 14 additions & 2 deletions

File tree

.github/workflows/lint.yaml

Lines changed: 14 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -27,11 +27,23 @@ jobs:
2727
with:
2828
version: latest
2929

30+
# npm (not pnpm) is intentional: remark-cli is installed globally by the
31+
# action at /usr/local/lib/node_modules/. pnpm's global store is not on
32+
# that resolution path, so remark-cli would fall back to resolving
33+
# remark-mdx from the project's node_modules, where @mdx-js/react pulls
34+
# in mdast-util-mdx-jsx@3 — incompatible with remark-cli@10's bundled
35+
# unified v10 stack. npm -g puts remark-mdx@2 next to remark-cli so the
36+
# versions stay compatible. install_deps: false prevents the action from
37+
# running npm install and reintroducing the incompatible project deps.
38+
- name: Install remark-mdx globally
39+
run: npm install -g remark-mdx@2
40+
3041
- name: remark-lint
3142
uses: reviewdog/action-remark-lint@v5
3243
with:
3344
github_token: ${{ secrets.GITHUB_TOKEN }}
34-
reporter: github-pr-check
45+
reporter: github-pr-review
3546
fail_level: "warning"
3647
level: "warning"
37-
remark_args: "--use=remark-preset-lint-recommended --use=remark-mdx"
48+
install_deps: false
49+
remark_args: "--use=remark-preset-lint-recommended --use=remark-mdx --ext .md,.mdx"

0 commit comments

Comments
 (0)