first pass on llm example - #160
Merged
Merged
Conversation
Contributor
|
Member
|
Only comment is to name the page, "Run a HF model" or similar as we may add another page on running a model with vLLM later. |
Contributor
Author
|
Sounds good. I made the requested change. Let me know if you think of anything else. |
Contributor
Author
|
Apologies, I thought I set you as a reviewer when I made the PR, @s-sajid-ali. |
Member
|
No worries, this is good to go now. If you have a moment, maybe add the script to https://github.com/NYU-RTS/rts-docs-examples ? |
s-sajid-ali
approved these changes
Aug 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I can add other pages before we merge this PR, but I thought we might want to do it sooner rather than later, to keep others from duplicating work. Let me know what you think @s-sajid-ali
Also, please let me know if you see any corrections I need to make or have any suggestions. Thanks!