From b9f735f59090f2e3f036ee6cede0d56e0ede7ff0 Mon Sep 17 00:00:00 2001 From: Sajid Ali Date: Fri, 10 Jul 2026 14:20:53 -0400 Subject: [PATCH 1/8] reviewdog change reporter --- .github/workflows/lint.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/lint.yaml b/.github/workflows/lint.yaml index b941c131d5..299023f5d9 100644 --- a/.github/workflows/lint.yaml +++ b/.github/workflows/lint.yaml @@ -31,7 +31,7 @@ jobs: uses: reviewdog/action-remark-lint@v5 with: github_token: ${{ secrets.GITHUB_TOKEN }} - reporter: github-pr-check + reporter: github-pr-review fail_level: "warning" level: "warning" remark_args: "--use=remark-preset-lint-recommended --use=remark-mdx" From f8ed7610396b541084cb96d646806099a573b325 Mon Sep 17 00:00:00 2001 From: Sajid Ali Date: Fri, 10 Jul 2026 14:23:18 -0400 Subject: [PATCH 2/8] introduce bug to test new reporter --- .../02_HPC_Accounts/01_getting_and_renewing_an_account.mdx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/hpc/01_getting_started/02_HPC_Accounts/01_getting_and_renewing_an_account.mdx b/docs/hpc/01_getting_started/02_HPC_Accounts/01_getting_and_renewing_an_account.mdx index 5d41149ae9..2d948b8cce 100644 --- a/docs/hpc/01_getting_started/02_HPC_Accounts/01_getting_and_renewing_an_account.mdx +++ b/docs/hpc/01_getting_started/02_HPC_Accounts/01_getting_and_renewing_an_account.mdx @@ -15,7 +15,7 @@ This section deals with the eligibility for getting HPC accounts, the process to :::info -- All **sponsored accounts** will be created for a period of 12 months, at which point a renewal process is required to continue to use the clusters +- All **sponsored accounts** will be created for a period of 12 months, at which point a renewal process is required to continue to use the clusters - Faculty, students, and staff from the **NYU School of Medicine** require the sponsorship of an eligible NYU faculty member to access the NYU HPC clusters - **Non-NYU Researchers** who are collaborating with NYU researchers must obtain an affiliate status before applying for an NYU HPC account From 63434c5643334154b60b20c9d01f812cfe9bb2e0 Mon Sep 17 00:00:00 2001 From: Sajid Ali Date: Fri, 10 Jul 2026 14:27:12 -0400 Subject: [PATCH 3/8] check mdx --- .github/workflows/lint.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/lint.yaml b/.github/workflows/lint.yaml index 299023f5d9..39e7b1225c 100644 --- a/.github/workflows/lint.yaml +++ b/.github/workflows/lint.yaml @@ -34,4 +34,4 @@ jobs: reporter: github-pr-review fail_level: "warning" level: "warning" - remark_args: "--use=remark-preset-lint-recommended --use=remark-mdx" + remark_args: "--use=remark-preset-lint-recommended --use=remark-mdx --ext .mdx" From a106ec155a295f9e2e538aa1bc518f739ec0ce28 Mon Sep 17 00:00:00 2001 From: Sajid Ali Date: Fri, 10 Jul 2026 14:32:39 -0400 Subject: [PATCH 4/8] check mdx --- .github/workflows/lint.yaml | 3 +++ 1 file changed, 3 insertions(+) diff --git a/.github/workflows/lint.yaml b/.github/workflows/lint.yaml index 39e7b1225c..7b10bc794f 100644 --- a/.github/workflows/lint.yaml +++ b/.github/workflows/lint.yaml @@ -27,6 +27,9 @@ jobs: with: version: latest + - name: Install remark-mdx globally + run: pnpm add -g remark-mdx + - name: remark-lint uses: reviewdog/action-remark-lint@v5 with: From 6a0325a51ef3d9efd339c9a78946560ddf416175 Mon Sep 17 00:00:00 2001 From: Sajid Ali Date: Fri, 10 Jul 2026 14:40:03 -0400 Subject: [PATCH 5/8] fix remark-mdx version conflict with remark-cli global install Co-Authored-By: Claude Sonnet 4.6 --- .github/workflows/lint.yaml | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/.github/workflows/lint.yaml b/.github/workflows/lint.yaml index 7b10bc794f..1b0f8730f5 100644 --- a/.github/workflows/lint.yaml +++ b/.github/workflows/lint.yaml @@ -28,7 +28,7 @@ jobs: version: latest - name: Install remark-mdx globally - run: pnpm add -g remark-mdx + run: npm install -g remark-mdx@2 - name: remark-lint uses: reviewdog/action-remark-lint@v5 @@ -37,4 +37,5 @@ jobs: reporter: github-pr-review fail_level: "warning" level: "warning" + install_deps: false remark_args: "--use=remark-preset-lint-recommended --use=remark-mdx --ext .mdx" From 0e3ec084f09da4ff7a7ce1d17435a59eb752f00b Mon Sep 17 00:00:00 2001 From: Sajid Ali Date: Fri, 10 Jul 2026 14:42:15 -0400 Subject: [PATCH 6/8] add comments explaining npm vs pnpm for remark-mdx global install Co-Authored-By: Claude Sonnet 4.6 --- .github/workflows/lint.yaml | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/.github/workflows/lint.yaml b/.github/workflows/lint.yaml index 1b0f8730f5..609e2cf52c 100644 --- a/.github/workflows/lint.yaml +++ b/.github/workflows/lint.yaml @@ -27,6 +27,14 @@ jobs: with: version: latest + # npm (not pnpm) is intentional: remark-cli is installed globally by the + # action at /usr/local/lib/node_modules/. pnpm's global store is not on + # that resolution path, so remark-cli would fall back to resolving + # remark-mdx from the project's node_modules, where @mdx-js/react pulls + # in mdast-util-mdx-jsx@3 — incompatible with remark-cli@10's bundled + # unified v10 stack. npm -g puts remark-mdx@2 next to remark-cli so the + # versions stay compatible. install_deps: false prevents the action from + # running npm install and reintroducing the incompatible project deps. - name: Install remark-mdx globally run: npm install -g remark-mdx@2 From 5669788798a08fbb5cd288d5788c38a51e450c08 Mon Sep 17 00:00:00 2001 From: Sajid Ali Date: Fri, 10 Jul 2026 14:50:24 -0400 Subject: [PATCH 7/8] check md and mdx --- .github/workflows/lint.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/lint.yaml b/.github/workflows/lint.yaml index 609e2cf52c..9a7b740c16 100644 --- a/.github/workflows/lint.yaml +++ b/.github/workflows/lint.yaml @@ -46,4 +46,4 @@ jobs: fail_level: "warning" level: "warning" install_deps: false - remark_args: "--use=remark-preset-lint-recommended --use=remark-mdx --ext .mdx" + remark_args: "--use=remark-preset-lint-recommended --use=remark-mdx --ext .md,.mdx" From ddc02396e2206a02246ad6143c03039962ba2730 Mon Sep 17 00:00:00 2001 From: Sajid Ali Date: Fri, 10 Jul 2026 15:08:11 -0400 Subject: [PATCH 8/8] fix the bug that was introduced now that reviewdog works as expected --- .../02_HPC_Accounts/01_getting_and_renewing_an_account.mdx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/hpc/01_getting_started/02_HPC_Accounts/01_getting_and_renewing_an_account.mdx b/docs/hpc/01_getting_started/02_HPC_Accounts/01_getting_and_renewing_an_account.mdx index 2d948b8cce..5d41149ae9 100644 --- a/docs/hpc/01_getting_started/02_HPC_Accounts/01_getting_and_renewing_an_account.mdx +++ b/docs/hpc/01_getting_started/02_HPC_Accounts/01_getting_and_renewing_an_account.mdx @@ -15,7 +15,7 @@ This section deals with the eligibility for getting HPC accounts, the process to :::info -- All **sponsored accounts** will be created for a period of 12 months, at which point a renewal process is required to continue to use the clusters +- All **sponsored accounts** will be created for a period of 12 months, at which point a renewal process is required to continue to use the clusters - Faculty, students, and staff from the **NYU School of Medicine** require the sponsorship of an eligible NYU faculty member to access the NYU HPC clusters - **Non-NYU Researchers** who are collaborating with NYU researchers must obtain an affiliate status before applying for an NYU HPC account