src/js/statuspage.mjs fix validAlert(): check impact, not status

da70 · da70 · commit 878bd0770240 · 2026-05-28T15:33:26.000-04:00
diff --git a/src/js/statuspage.mjs b/src/js/statuspage.mjs
@@ -49,7 +49,7 @@ class Statuspage {
     }
 
     validAlert() {
-        return this.#alert && this.#alert.status !== IMPACT_NONE;
+        return this.#alert && this.#alert.impact !== IMPACT_NONE;
     }
 }
 
diff --git a/test/e2e/tests/golden/incident_none_update-1_investigating.html b/test/e2e/tests/golden/incident_none_update-1_investigating.html
@@ -5,7 +5,7 @@
     <meta name="viewport" content="width=device-width, initial-scale=1.0">
     <title>NYU Libraries</title>
   <link rel="stylesheet" type="text/css" href="http://[HOSTNAME]:5173/index.min.css"></head>
-  <body><aside id="nyulibraries-alert-banner" class="nyulibraries-alert-banner alert-red" aria-label="Service Alert Banner">Test incident: impact=none <a href="https://stspg.io/h77hq2ns91rf" target="_blank">See more</a></aside>
+  <body>
     <div class="container">
       <h1>NYU Libraries Header</h1>
 
diff --git a/test/e2e/tests/golden/incident_none_update-2_identified.html b/test/e2e/tests/golden/incident_none_update-2_identified.html
@@ -5,7 +5,7 @@
     <meta name="viewport" content="width=device-width, initial-scale=1.0">
     <title>NYU Libraries</title>
   <link rel="stylesheet" type="text/css" href="http://[HOSTNAME]:5173/index.min.css"></head>
-  <body><aside id="nyulibraries-alert-banner" class="nyulibraries-alert-banner alert-orange" aria-label="Service Alert Banner">Test incident: impact=none <a href="https://stspg.io/h77hq2ns91rf" target="_blank">See more</a></aside>
+  <body>
     <div class="container">
       <h1>NYU Libraries Header</h1>
 
diff --git a/test/e2e/tests/golden/incident_none_update-3_monitoring.html b/test/e2e/tests/golden/incident_none_update-3_monitoring.html
@@ -5,7 +5,7 @@
     <meta name="viewport" content="width=device-width, initial-scale=1.0">
     <title>NYU Libraries</title>
   <link rel="stylesheet" type="text/css" href="http://[HOSTNAME]:5173/index.min.css"></head>
-  <body><aside id="nyulibraries-alert-banner" class="nyulibraries-alert-banner alert-green" aria-label="Service Alert Banner">Test incident: impact=none <a href="https://stspg.io/h77hq2ns91rf" target="_blank">See more</a></aside>
+  <body>
     <div class="container">
       <h1>NYU Libraries Header</h1>
 

Original file line number	Diff line number	Diff line change
`@@ -49,7 +49,7 @@ class Statuspage {`
`49`	`49`	`}`
`50`	`50`
`51`	`51`	`validAlert() {`
`52`		`- return this.#alert && this.#alert.status !== IMPACT_NONE;`
	`52`	`+ return this.#alert && this.#alert.impact !== IMPACT_NONE;`
`53`	`53`	`}`
`54`	`54`	`}`
`55`	`55`