Fix Eclipse plugin review issues

- Write the API key directly into ~/.devglobe/config.toml instead of running
  devglobe-core setup, so first-run setup works before the core binary is
  downloaded and the key never appears in the process list
- Report activity on document edits, not just editor switches, so typing in a
  single file keeps you visible (the daemon stops sending heartbeats after a
  minute without activity)
- Download the core off the UI thread so Connect no longer freezes Eclipse, and
  make the client field volatile
- Actually send the shutdown message to the daemon on stop
- Always use the win-x64 core on Windows since no win-arm64 build is published
- Require JavaSE-17 to match the compile target so the bundle loads on a
  Java 17 Eclipse
- Keep routine confirmations in the status line instead of modal dialogs, and
  clear it with timerExec instead of a thread per toast
- Remove the status bar widget that was never registered, along with its README
  claim

Author: CaadriFR

eclipse-plugin/META-INF/MANIFEST.MF

@@ -5,7 +5,7 @@ Bundle-SymbolicName: xyz.devglobe.eclipse; singleton:=true
 Bundle-Version: 2.0.1.qualifier
 Bundle-Activator: xyz.devglobe.eclipse.core.DevGlobePlugin
 Bundle-Vendor: DevGlobe
-Bundle-RequiredExecutionEnvironment: JavaSE-21
+Bundle-RequiredExecutionEnvironment: JavaSE-17
 Require-Bundle: org.eclipse.ui,
  org.eclipse.core.runtime,
  org.eclipse.swt,

eclipse-plugin/README.md

@@ -39,7 +39,6 @@ Visibility settings (anonymous mode, repo sharing, profile mode) are managed on
 | **Platform detection** | Sends your OS (macOS, Windows or Linux) alongside each heartbeat so it appears on your profile. |
 | **Git integration** | Detects your repo from the git remote. Commit data is never read or sent by the plugin. |
 | **Status message** | Write what you're working on — visible on your globe profile. Supports empty to clear. |
-| **Status bar** | Displays your coding time for today (e.g. `2h 15m`) in the Eclipse status bar. |
 | **Notifications** | Toast notifications in the Eclipse status line for connection events, errors, and status changes. |
 
 ### Sidebar
@@ -188,10 +187,9 @@ eclipse-plugin/
     │   ├── TrackerState.java         # Immutable state data class
     │   └── LanguageService.java      # File extension → language mapping
     ├── auth/
-    │   └── ConfigWriter.java         # Spawns devglobe-core setup subprocess
+    │   └── ConfigWriter.java         # Reads/writes ~/.devglobe/config.toml
     ├── ui/
     │   ├── DevGlobeView.java             # Sidebar ViewPart (login + dashboard)
-    │   ├── DevGlobeStatusBarContribution.java  # Status bar widget
     │   ├── DocumentTracker.java          # Editor activity listener
     │   └── Notifier.java                 # Toast notifications via status line
     └── actions/

eclipse-plugin/src/main/java/xyz/devglobe/eclipse/auth/ConfigWriter.java

@@ -8,13 +8,13 @@
 import java.util.regex.Matcher;
 import java.util.regex.Pattern;
 
-import xyz.devglobe.eclipse.core.CoreDownloader;
 import xyz.devglobe.eclipse.core.DevGlobePlugin;
 
 /**
  * Reads and writes the DevGlobe config.toml file (~/.devglobe/config.toml).
- * API key writes delegate to {@code devglobe-core setup <key>} so the config
- * format always matches what the core expects.
+ * The API key is written directly into the TOML root so setup works before
+ * the core binary has been downloaded, and the key never appears on a process
+ * command line.
  */
 public final class ConfigWriter {
 
@@ -37,34 +37,40 @@ public static File logPath() {
     // ── API Key ──────────────────────────────────────────────────────────
 
     /**
-     * Writes the API key by running {@code devglobe-core setup <key>}.
-     * This ensures the config format always matches what the core expects.
+     * Writes the API key into the {@code api_key} root entry of config.toml,
+     * preserving any other settings and sections. Written with 0600 permissions.
      */
     public static void writeApiKey(String apiKey) {
         try {
-            File binary = CoreDownloader.getBinaryPath();
-            if (!binary.exists()) {
-                DevGlobePlugin.log("devglobe-core not found, cannot write API key");
-                return;
-            }
-
-            ProcessBuilder pb = new ProcessBuilder(
-                    binary.getAbsolutePath(), "setup", apiKey);
-            pb.directory(devglobeDir());
-            pb.redirectErrorStream(true);
+            File dir = devglobeDir();
+            if (!dir.exists()) dir.mkdirs();
 
-            Process process = pb.start();
-            int exitCode = process.waitFor();
+            File configFile = configPath();
+            List<String> lines = configFile.exists()
+                    ? new ArrayList<>(Files.readAllLines(configFile.toPath()))
+                    : new ArrayList<>();
 
-            if (exitCode != 0) {
-                String error = new String(process.getInputStream().readAllBytes());
-                DevGlobePlugin.log("devglobe-core setup failed (exit " + exitCode + "): " + error);
+            String keyLine = "api_key = \"" + escapeToml(apiKey) + "\"";
+            int idx = findRootApiKeyIndex(lines);
+            if (idx >= 0) {
+                lines.set(idx, keyLine);
+            } else {
+                lines.add(0, keyLine);
             }
-        } catch (Exception e) {
-            DevGlobePlugin.log("Failed to write API key via devglobe-core: " + e.getMessage());
+
+            String output = String.join("\n", lines).replaceAll("\n{3,}", "\n\n");
+            if (!output.endsWith("\n")) output += "\n";
+            Files.writeString(configFile.toPath(), output);
+            setRestrictivePermissions(configFile);
+        } catch (IOException e) {
+            DevGlobePlugin.log("Failed to write API key: " + e.getMessage());
         }
     }
 
+    private static String escapeToml(String s) {
+        return s.replace("\\", "\\\\").replace("\"", "\\\"");
+    }
+
     public static boolean hasApiKey() {
         try {
             File configFile = configPath();

eclipse-plugin/src/main/java/xyz/devglobe/eclipse/core/CoreClient.java

@@ -1,6 +1,7 @@
 package xyz.devglobe.eclipse.core;
 
 import java.io.*;
+import java.util.concurrent.TimeUnit;
 
 /**
  * JSON-line IPC client for the devglobe-core subprocess.
@@ -42,7 +43,6 @@ public synchronized boolean start(String binaryPath) {
         try {
             ProcessBuilder pb = new ProcessBuilder(binaryPath, "daemon");
             pb.redirectErrorStream(false);
-            pb.environment().remove("RUST_LOG"); // don't pollute
 
             process = pb.start();
             writer = new BufferedWriter(new OutputStreamWriter(process.getOutputStream()));
@@ -61,13 +61,21 @@ public synchronized boolean start(String binaryPath) {
     }
 
     public synchronized void stop() {
-        running = false;
         try {
             if (writer != null) {
                 sendShutdown();
-                writer.close();
+                writer.flush();
             }
         } catch (IOException ignored) {}
+        running = false;
+        try {
+            if (process != null) process.waitFor(1, TimeUnit.SECONDS);
+        } catch (InterruptedException ignored) {
+            Thread.currentThread().interrupt();
+        }
+        try {
+            if (writer != null) writer.close();
+        } catch (IOException ignored) {}
         if (process != null) process.destroyForcibly();
         if (readerThread != null) readerThread.interrupt();
         process = null;

eclipse-plugin/src/main/java/xyz/devglobe/eclipse/core/CoreDownloader.java

@@ -41,8 +41,8 @@ public static String detectPlatform() {
             platform = arch.contains("aarch64") || arch.contains("arm")
                     ? "linux-arm64" : "linux-x64";
         } else if (os.contains("win")) {
-            platform = arch.contains("aarch64") || arch.contains("arm")
-                    ? "win-arm64" : "win-x64";
+            // Only win-x64 is published; it runs under emulation on Windows ARM.
+            platform = "win-x64";
         } else {
             platform = "linux-x64"; // fallback
         }

eclipse-plugin/src/main/java/xyz/devglobe/eclipse/core/DevGlobeTracker.java

@@ -30,7 +30,7 @@ public static DevGlobeTracker getInstance() {
     private final List<Runnable> stateListeners = new ArrayList<>();
     private final AtomicBoolean starting = new AtomicBoolean(false);
     private final AtomicBoolean intentionalShutdown = new AtomicBoolean(false);
-    private CoreClient client;
+    private volatile CoreClient client;
 
     // ── Public API ───────────────────────────────────────────────────────
 
@@ -74,7 +74,11 @@ public void start() {
             starting.set(false);
             return;
         }
-        ensureCore();
+        // ensureCore() may download the core binary (blocking HTTP), so it must
+        // never run on the UI thread.
+        Thread worker = new Thread(this::ensureCore, "DevGlobe-Start");
+        worker.setDaemon(true);
+        worker.start();
     }
 
     public void pause() {

eclipse-plugin/src/main/java/xyz/devglobe/eclipse/core/Notifier.java

@@ -46,12 +46,12 @@ public static void error(String message) {
     }
 
     /**
-     * Show a confirmation notification that the user is guaranteed to see.
-     * Uses the status line if available, but always falls back to a dialog
-     * if the status line cannot be reached.
+     * Show a confirmation notification in the status line. Routine confirmations
+     * (paused, resumed, reconnected, status updated) should not interrupt with a
+     * modal dialog — only errors do.
      */
     public static void confirm(String message) {
-        show(Severity.INFO, message, true);
+        show(Severity.INFO, message, false);
     }
 
     // ── Implementation ───────────────────────────────────────────────────
@@ -195,25 +195,14 @@ private static StatusLineManager getStatusLineManager(IWorkbenchWindow window) {
         }
     }
 
-    /** Clear the status-line message after a short delay. */
+    /** Clear the status-line message after a short delay, on the UI thread. */
     private static void scheduleClear(Display display, StatusLineManager slm) {
-        Thread clearer = new Thread(() -> {
+        if (display == null || display.isDisposed()) return;
+        display.timerExec(5_000, () -> {
             try {
-                Thread.sleep(5_000);
-            } catch (InterruptedException ignored) {}
-            // Check if display is still valid before using it
-            Display currentDisplay = PlatformUI.isWorkbenchRunning() ? PlatformUI.getWorkbench().getDisplay() : null;
-            if (currentDisplay == null || currentDisplay.isDisposed()) {
-                return;
-            }
-            currentDisplay.asyncExec(() -> {
-                try {
-                    slm.setMessage(null);
-                    slm.setErrorMessage(null);
-                } catch (Exception ignored) {}
-            });
-        }, "DevGlobe-Notifier-Clear");
-        clearer.setDaemon(true);
-        clearer.start();
+                slm.setMessage(null);
+                slm.setErrorMessage(null);
+            } catch (Exception ignored) {}
+        });
     }
 }