Skip to content
This repository was archived by the owner on Jan 24, 2021. It is now read-only.

Added .editorconfig#2035

Merged
thecodejunkie merged 1 commit into
NancyFx:masterfrom
khellang:editorconfig
Aug 26, 2015
Merged

Added .editorconfig#2035
thecodejunkie merged 1 commit into
NancyFx:masterfrom
khellang:editorconfig

Conversation

@khellang
Copy link
Copy Markdown
Member

Nicked from https://github.com/dotnet/corefx

An attempt at preventing this (indent_style = space, indent_size = 4) and this (trim_trailing_whitespace = true) in the future 😉

@thecodejunkie
Copy link
Copy Markdown
Member

What does this https://github.com/NancyFx/Nancy/pull/2035/files#diff-1e70daafb475c0ce3fef7d2728279182R11 do? Not add an extra blank line at the end of the file I hope?

Also, are all the Xml related settings compatible with the default indentation? Don't want it to affect all web/app.config etc files that we already have in our solution

@khellang
Copy link
Copy Markdown
Member Author

What does this https://github.com/NancyFx/Nancy/pull/2035/files#diff-1e70daafb475c0ce3fef7d2728279182R11 do? Not add an extra blank line at the end of the file I hope?

Yes. That's exactly what it does. Some background:
http://stackoverflow.com/questions/729692/why-should-files-end-with-a-newline
http://stackoverflow.com/questions/5813311/no-newline-at-end-of-file
https://robots.thoughtbot.com/no-newline-at-end-of-file

Also, are all the Xml related settings compatible with the default indentation?

Probably not (is there an existing standard?), but it's not as if this magically goes through all config files and changes them. This will make sure the indentation is changed correctly over time.

@thecodejunkie
Copy link
Copy Markdown
Member

You and your "I'll make perfect sense" personality ;)

@thecodejunkie thecodejunkie added this to the 1.3 milestone Aug 26, 2015
thecodejunkie added a commit that referenced this pull request Aug 26, 2015
@thecodejunkie thecodejunkie merged commit f2b8337 into NancyFx:master Aug 26, 2015
@khellang khellang deleted the editorconfig branch August 26, 2015 12:27
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants