fix: remove strip-ansi runtime dependency#644
Draft
2409324124 wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #643.
Replaces the runtime
strip-ansiimport inansi-truncatewith Node built-instripVTControlCharacters. This keeps the published CLI from requiring a dev-only package at runtime and avoids theERR_MODULE_NOT_FOUNDfailure when the package is installed without dev dependencies.Type of Change
Testing
Automated Tests
source/utils/ansi-truncate.spec.tspnpm test:ava source/utils/ansi-truncate.spec.tsgit diff --check HEADpnpm test:allcompletes successfully)pnpm test:allwas attempted locally, but the current sandbox fails unrelated suites that require local sockets, network access, or subprocess permissions, plus existing model/pricing assertions. The targeted regression test for this fix passes.Manual Testing
N/A: this change only removes a runtime ANSI-stripping dependency from a utility module.
Checklist
N/A: no logging path was changed.