Remove libGDSII dependency; demonstrate gdstk in the tutorials#3244
Open
oskooi wants to merge 2 commits into
Open
Remove libGDSII dependency; demonstrate gdstk in the tutorials#3244oskooi wants to merge 2 commits into
oskooi wants to merge 2 commits into
Conversation
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Collaborator
|
I don't want to break working code. So:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #3206.
Context
libGDSII is an optional Meep dependency used to import GDSII layout files (polygons → Meep prisms / volumes). It is no longer maintained. This change removes libGDSII entirely from the Meep codebase — the build hooks, the C++ implementation, the SWIG/Python wrappers, the GDS tests, and the build documentation that referenced it. The Meep-native GDS functions that depended on libGDSII (
get_GDSII_prisms,GDSII_vol,GDSII_layers,with_libGDSII,set_geometry_from_GDSII,get_GDSII_prism,get_GDSII_volume,get_GDSII_layers) are therefore removed as well.Rather than wiring a replacement library into Meep's build, the gdstk Python package is demonstrated directly in the Python tutorials: users read GDS polygons with gdstk and build
mp.Prism/mp.Volumeobjects themselves. gdstk is not added to Meep's build, requirements, or CI — it is a user-side tool shown in the docs.Additionally, the GDS-import paths in the Python tests are deleted (analytic-prism coverage remains), and CI only has its libGDSII steps removed (gdstk is not added to CI).
Scope decisions
get_center_and_size(generaly utility, used bytest_simulation.py) is kept.coupler.gdsexample asset is kept (the rewritten tutorial reads it via gdstk);python/tests/data/bend-flux.gdsandpython/tests/data/spiral.gdsare removed.