Clean up dead branches caused by hard-coded local flags

[dareumnam]

Issue overview

Cppcheck is flagging a couple of knownConditionTrueFalse cases that look like dead branch logic caused by hard-coded local flags.

Two current examples:

1. In ThermalISO15099Calc::Calc_ISO15099 (here and there), UnshadedDebug is initialized to 0 with a comment indicating unshaded debug output was removed for now. Both if (files.WriteDebugOutput && (UnshadedDebug == 1)) blocks are therefore unreachable. This looks like leftover disabled debug code.
2. In WindowEquivalentLayer::VB_SOL46_CURVE (here), CORR is initialized to 1 and never modified, so if (CORR > 0) is always true and the else path is unreachable. This looks like leftover on/off flag logic for slat-curvature correction rather than an active runtime branch.

Suggested cleanup:

• remove dead branches if the behavior is intentionally fixed/disabled, or
• reconnect the flags to real configuration/input paths if they are supposed to remain functional.

It would also reduce cppcheck noise and make the code intent clearer.

Operating System (Multiple choices)

Windows

Operating System Version

11

Version of EnergyPlus

26.1.0

Unmethours link or helpdesk ticket number

N/A

Defect file

No response

[dareumnam]

@rraustad @mitchute I’m inclined to remove these dead branches, but if you believe they are intended to remain functional and we should reconnect the flags to active code paths, please let me know and I can make the necessary changes.

[rraustad]

I’m inclined to remove these dead branches

Well, for item 1 the debug code that is intentionally not used now could be used in the future (not likely but could be). I think I would comment those 2 blocks instead of deleting them but that's up to you and @mitchute. For item 2 it looks like you're right and the else is not needed. but I don't know enough about WindowEquivalentLayer to be sure.