Adding CO2 Hydrogenation as a methanol production technology#137
Merged
jmartin4u merged 117 commits intoNatLabRockies:developfrom Aug 15, 2025
Merged
Adding CO2 Hydrogenation as a methanol production technology#137jmartin4u merged 117 commits intoNatLabRockies:developfrom
jmartin4u merged 117 commits intoNatLabRockies:developfrom
Conversation
Was unable to delete locally, git tracking issue?
Was unable to delete locally, git tracking issue?
johnjasa
approved these changes
Aug 12, 2025
Collaborator
johnjasa
left a comment
johnjasa
left a comment
There was a problem hiding this comment.
I like this a lot! Your organization of the methanol production methods and the associated examples is very clear. I also like the breakdown of LCOM from different sources in the finance model.
I pushed some minor changes and have a request for docstring update; ready to merge after that imo.
| @define | ||
| class MethanolPerformanceConfig(BaseConfig): | ||
| plant_capacity_kgpy: float = field() | ||
| plant_capacity_flow: str = field(validator=contains(["hydrogen", "methanol"])) |
Collaborator
There was a problem hiding this comment.
Update docstrings throughout for this additional param
kbrunik
approved these changes
Aug 13, 2025
Collaborator
kbrunik
left a comment
kbrunik
left a comment
There was a problem hiding this comment.
Thanks for the good work Jonathan!
| @@ -0,0 +1,10 @@ | |||
| # Methanol model | |||
Collaborator
There was a problem hiding this comment.
I would recommend adding your publication here to reference and say methods of the models are further described there.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding CO2 Hydrogenation as a methanol production technology
Previously, the only methanol production technology included was Steam Methane Reforming (SMR), which uses natural gas as its main feedstock and does not connect to other H2I converters. Now, the methanol production technology of CO2 Hydrogenation has been added, which uses hydrogen as a feedstock and connects with the existing electrolyzer converter.
PR Checklist
CHANGELOG.mdhas been updated to describe the changes made in this PRdocs/files are up-to-date, or added when necessaryRelated issues
Impacted areas of the software
.gitignore: Kept output files that were generated in the/examples/directory from being trackedchangelog.md: Noted the addition of CO2 hydrogen modeldocs/technology_models/methanol.md: Wrote a descriptive doc of the methanol modelsexamples/03_methanol/: Updated examples and split them into folders for each methanol production technologiesexamples/03_methanol/smr/: Updated this existing example of SMR and placed it in its own folderexamples/03_methanol/co2_hydrogenation/: Added this new example of CO2 hydrogenationh2integrate/converters/methanol/: Updated to include CO2 hydrogenation technologyh2integrate/converters/methanol/methanol_baseclass.py: Removed some variables that are not used for all methanol production technologies, changed the naming convention to follow_in/_out/_consumeconvention (see below)h2integrate/converters/methanol/smr_methanol_plant.py: Added some variables that are used by SMR specifically (not all methanol technologies), changed the naming convention to follow_in/_out/_consumeconvention (see below)h2integrate/converters/methanol/co2h_methanol_plant.py: Created a new CO2 Hydrogenation model that follows the same structure and naming conventions as the SMR modelcore/supported_models.py: Added the new CO2 hydrogenation model as an H2I-supported modeltests/test_all_examples.py: Added tests of the methanol examplesAdditional supporting information
Test results, if applicable