-
Notifications
You must be signed in to change notification settings - Fork 38
Added variable o&m #235
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Added variable o&m #235
Changes from all commits
Commits
Show all changes
23 commits
Select commit
Hold shift + click to select a range
63190d6
added variable into cost and finance models
elenya-grant e8b1317
added plant life input to cost model tests that were missing it
elenya-grant ce816a5
added varom output to wombat model
elenya-grant 10f05e5
updated CostModelBaseClass doc string
elenya-grant cd5ac48
updated changelog
elenya-grant 57575aa
added initial test for variable om in profast and updated profast script
elenya-grant 8e3a5f5
updated added finance tests
elenya-grant 585cd45
updated units in new finance tests
elenya-grant f21b12c
merged upstream
elenya-grant a0fcda9
added plant life to test plant configs
elenya-grant 91899f0
Merge branch 'develop' into dev/var_om
johnjasa 8db5a9c
merged in develop
elenya-grant e116d23
updated feedstock cost model and natgas test
elenya-grant e3134d7
fixed failing tests in feedstock and custom elec cost
elenya-grant bc9824f
merged develop into branch
elenya-grant 1518b68
updated variable om tests in test_finance.py
elenya-grant 14df797
Merge branch 'develop' into dev/var_om
johnjasa 68c785d
renamed attr_filter
johnjasa 3cfaeaf
Using create_years_of_operation in tests
johnjasa 34f57f9
Naming fix
johnjasa 2d3259a
Fixing order of args
johnjasa 352e344
Mods due to review feedback
johnjasa 44d5bf5
Merge branch 'develop' into dev/var_om
johnjasa File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You're adding this output as part of this PR but not setting it in the compute. Is this intentional and will it be part of the follow-on PRs you mention in the body?