Rename pipe and cable transport types to pipe_passthrough and cable_passthrough#701
Rename pipe and cable transport types to pipe_passthrough and cable_passthrough#701johnjasa wants to merge 3 commits intoNatLabRockies:developfrom
pipe and cable transport types to pipe_passthrough and cable_passthrough#701Conversation
|
Thanks for making these changes to resolve this issue! I hate to be this person but - I kinda don't like it (ah! even though I made the issue!) The reason(s) I don't like it - at least don't like it coming in now (perhaps it'll make sense in the future) is that:
|
|
Thanks for you comment, @elenya-grant, this is very helpful! @jaredthomas68, based on what Elenya said, what do you think? Do we need this PR or no thank you? |
|
As I have given this more thought and the code has continued to progress, I lean towards not renaming them. I think it may be better to gradually transition to full tech models for transport with cost and performance models. The existing pipe and cable components could have a set cost and a simple efficiency that could be set to 0 and 1, respectively, to mimic the current behavior. Eventually it would be great to have transport models that can use start and end lat lon from two site specifications and open the way for routing (via reV perhaps). I think making the existing components slightly more general will be a better step forward than giving them pass through names. |
|
Thanks @elenya-grant and @jaredthomas68! I'll close this PR as not relevant. |
Rename
pipeandcabletransport types topipe_passthroughandcable_passthroughRenames the protected transport type identifiers
pipetopipe_passthroughandcabletocable_passthroughto better indicate their pass-through (no-loss) nature. This makes the naming more specific and leaves room for future transport components that model actual losses.Changes include:
pipe_passthrough.py/cable_passthrough.pywith renamed classes (PipePassthroughPerformanceModel,CablePassthroughPerformanceModel)supported_modelsregistry,reserved_techs, andno_cost_modelsSection 1: Type of Contribution
Section 2: Draft PR Checklist
TODO:
Type of Reviewer Feedback Requested (on Draft PR)
Structural feedback:
Implementation feedback:
Other feedback:
Section 3: General PR Checklist
docs/files are up-to-date, or added when necessaryCHANGELOG.md"A complete thought. [PR XYZ]((https://github.com/NatLabRockies/H2Integrate/pull/XYZ)", where
XYZshould be replaced with the actual number.Section 4: Related Issues
Resolves #560