Skip to content

Enable CI Tests When PRs Added to Auto-Merge#752

Merged
johnjasa merged 1 commit into
NatLabRockies:mainfrom
RHammond2:patch/pr-runs
May 14, 2026
Merged

Enable CI Tests When PRs Added to Auto-Merge#752
johnjasa merged 1 commit into
NatLabRockies:mainfrom
RHammond2:patch/pr-runs

Conversation

@RHammond2

Copy link
Copy Markdown
Collaborator

Enable CI Tests When PRs Added to Auto-Merge

Adds the auto_merge_enabled status to valid statuses that kick-off a PRs CI test runner. This was previously confused with enqueued, so now both have been enabled.

Section 1: Type of Contribution

  • Feature Enhancement
    • Framework
    • New Model
    • Updated Model
    • Tools/Utilities
    • Other (please describe):
  • Bug Fix
  • Documentation Update
  • CI Changes
  • Other (please describe):

Section 2: Draft PR Checklist

  • Open draft PR
  • Describe the feature that will be added
  • Fill out TODO list steps
  • Describe requested feedback from reviewers on draft PR
  • Complete Section 7: New Model Checklist (if applicable)

TODO:

  • Step 1
  • Step 2

Type of Reviewer Feedback Requested (on Draft PR)

Structural feedback:

Implementation feedback:

Other feedback:

Section 3: General PR Checklist

  • PR description thoroughly describes the new feature, bug fix, etc.
  • Added tests for new functionality or bug fixes
  • Tests pass (If not, and this is expected, please elaborate in the Section 6: Test Results)
  • Documentation
    • Docstrings are up-to-date
    • Related docs/ files are up-to-date, or added when necessary
    • Documentation has been rebuilt successfully
    • Examples have been updated (if applicable)
  • CHANGELOG.md
    • At least one complete sentence has been provided to describe the changes made in this PR
    • After the above, a hyperlink has been provided to the PR using the following format:
      "A complete thought. [PR XYZ]((https://github.com/NatLabRockies/H2Integrate/pull/XYZ)", where
      XYZ should be replaced with the actual number.

Section 4: Related Issues

N/A

Section 5: Impacted Areas of the Software

Section 5.1: New Files

  • path/to/file.extension
    • method1: What and why something was changed in one sentence or less.

Section 5.2: Modified Files

  • .github/workflows/ci.yml: Adds auto_merge_enabled to pull request types.

Section 6: Additional Supporting Information

#664 tests won't run after @johnjasa added the PR to auto-merge.

Section 7: Test Results, if applicable

N/A

Section 8 (Optional): New Model Checklist

  • Model Structure:
    • Follows established naming conventions outlined in docs/developer_guide/coding_guidelines.md
    • Used attrs class to define the Config to load in attributes for the model
      • If applicable: inherit from BaseConfig or CostModelBaseConfig
    • Added: initialize() method, setup() method, compute() method
      • If applicable: inherit from CostModelBaseClass
  • Integration: Model has been properly integrated into H2Integrate
    • Added to supported_models.py
    • If a new commodity_type is added, update create_financial_model in h2integrate_model.py
  • Tests: Unit tests have been added for the new model
    • Pytest-style unit tests
    • Unit tests are in a "test" folder within the folder a new model was added to
    • If applicable add integration tests
  • Example: If applicable, a working example demonstrating the new model has been created
    • Input file comments
    • Run file comments
    • Example has been tested and runs successfully in test_all_examples.py
  • Documentation:
    • Write docstrings using the Google style
    • Model added to the main models list in docs/user_guide/model_overview.md
      • Model documentation page added to the appropriate docs/ section
      • <model_name>.md is added to the _toc.yml
    • Run generate_class_hierarchy.py to update the class hierarchy diagram in docs/developer_guide/class_structure.md

@RHammond2 RHammond2 requested a review from johnjasa May 14, 2026 17:59
@RHammond2 RHammond2 added the infrastructure Anything relating to CI, project management, or non-code changes label May 14, 2026

@johnjasa johnjasa left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Rob!

@johnjasa johnjasa merged commit af03c23 into NatLabRockies:main May 14, 2026
1 of 2 checks passed
@RHammond2 RHammond2 deleted the patch/pr-runs branch May 14, 2026 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

infrastructure Anything relating to CI, project management, or non-code changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants