Skip to content

Commit a766a4a

Browse files
committed
Fixes possible "Could not identify surface type for surface" error.
1 parent fddd2df commit a766a4a

3 files changed

Lines changed: 18 additions & 15 deletions

File tree

Changelog.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -35,6 +35,7 @@ __Bugfixes__
3535
- Fixes excessive heat transfer when foundation wall interior insulation does not start from the top of the wall.
3636
- Fixes how relative paths are treated when using an OpenStudio Workflow.
3737
- Fixes possible simulation error if a slab has an ExposedPerimeter near zero.
38+
- Fixes possible "Could not identify surface type for surface" error.
3839
- BuildResidentialHPXML measure:
3940
- Fixes aspect ratio convention for single-family attached and multifamily dwelling units.
4041

HPXMLtoOpenStudio/measure.rb

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2442,9 +2442,11 @@ def self.set_surface_exterior(model, spaces, surface, hpxml_surface)
24422442
HPXML::LocationOtherNonFreezingSpace, HPXML::LocationOtherHousingUnit].include? exterior_adjacent_to
24432443
set_surface_otherside_coefficients(surface, exterior_adjacent_to, model, spaces)
24442444
elsif HPXML::conditioned_below_grade_locations.include? exterior_adjacent_to
2445-
surface.createAdjacentSurface(create_or_get_space(model, spaces, HPXML::LocationLivingSpace))
2445+
adjacent_surface = surface.createAdjacentSurface(create_or_get_space(model, spaces, HPXML::LocationLivingSpace)).get
2446+
adjacent_surface.additionalProperties.setFeature('SurfaceType', surface.additionalProperties.getFeatureAsString('SurfaceType').get)
24462447
else
2447-
surface.createAdjacentSurface(create_or_get_space(model, spaces, exterior_adjacent_to))
2448+
adjacent_surface = surface.createAdjacentSurface(create_or_get_space(model, spaces, exterior_adjacent_to)).get
2449+
adjacent_surface.additionalProperties.setFeature('SurfaceType', surface.additionalProperties.getFeatureAsString('SurfaceType').get)
24482450
end
24492451
end
24502452

HPXMLtoOpenStudio/measure.xml

Lines changed: 13 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -3,8 +3,8 @@
33
<schema_version>3.0</schema_version>
44
<name>hpxm_lto_openstudio</name>
55
<uid>b1543b30-9465-45ff-ba04-1d1f85e763bc</uid>
6-
<version_id>6a814a43-be01-41c7-9bdc-d6c9c9784f9b</version_id>
7-
<version_modified>20220919T151913Z</version_modified>
6+
<version_id>10580b32-165f-42f6-9cac-c78f14da333c</version_id>
7+
<version_modified>20220921T182550Z</version_modified>
88
<xml_checksum>D8922A73</xml_checksum>
99
<class_name>HPXMLtoOpenStudio</class_name>
1010
<display_name>HPXML to OpenStudio Translator</display_name>
@@ -547,17 +547,6 @@
547547
<usage_type>resource</usage_type>
548548
<checksum>A2B7F8E1</checksum>
549549
</file>
550-
<file>
551-
<version>
552-
<software_program>OpenStudio</software_program>
553-
<identifier>3.3.0</identifier>
554-
<min_compatible>3.3.0</min_compatible>
555-
</version>
556-
<filename>measure.rb</filename>
557-
<filetype>rb</filetype>
558-
<usage_type>script</usage_type>
559-
<checksum>4F98F3F7</checksum>
560-
</file>
561550
<file>
562551
<filename>test_defaults.rb</filename>
563552
<filetype>rb</filetype>
@@ -594,5 +583,16 @@
594583
<usage_type>resource</usage_type>
595584
<checksum>FBEFBFF9</checksum>
596585
</file>
586+
<file>
587+
<version>
588+
<software_program>OpenStudio</software_program>
589+
<identifier>3.3.0</identifier>
590+
<min_compatible>3.3.0</min_compatible>
591+
</version>
592+
<filename>measure.rb</filename>
593+
<filetype>rb</filetype>
594+
<usage_type>script</usage_type>
595+
<checksum>DCA18258</checksum>
596+
</file>
597597
</files>
598598
</measure>

0 commit comments

Comments
 (0)