Conversation
shorowit
commented
Apr 24, 2026
Comment on lines
+6306
to
+6309
| elsif water_heating_system.hpwh_voltage == HPXML::HPWHVoltage120Dedicated | ||
| cop = 3.6 | ||
| else # 120V shared | ||
| cop = 4.2 |
Contributor
Author
There was a problem hiding this comment.
Need to replace with equations based on UEF. @jmaguire1
Collaborator
There was a problem hiding this comment.
@shorowit: I spent a while today going back through how I did this the first time around, I think I'm largely set up to redo the same simulations to derive the COP/UEF correlations we need. Before I do that, we should make sure we're on the same page about what to use for UA, since that will have a small effect on the correlations I come up with. Once we have that sorted, it's not too hard to rerun all the simulations and compile the results into the correlations we need.
…d unit, not necessary for dedicated) to ensure curves produce 1.0 at nominal conditions
shorowit
commented
Jun 15, 2026
…HPXML into hpwh_120v # Conflicts: # Changelog.md # HPXMLtoOpenStudio/measure.xml # HPXMLtoOpenStudio/resources/hpxml_schematron/EPvalidator.sch # docs/source/workflow_inputs.rst # workflow/tests/base_results/results_simulations_bills.csv # workflow/tests/base_results/results_simulations_misc.csv
Contributor
Author
|
…HPXML into hpwh_120v # Conflicts: # HPXMLtoOpenStudio/measure.xml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Closes #1427.
Re-implements #1534 off the master branch. Uses the HPXML
HPWHVoltage/HasMixingValue/MixingValveSetpointelements (added here).Example docs for HPWH:
Checklist
Not all may apply:
EPvalidator.sch) has been updatedopenstudio tasks.rb update_hpxmls)HPXMLtoOpenStudio/tests/test*.rband/orworkflow/tests/test*.rb)openstudio tasks.rb update_measureshas been run